mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-09-08 12:49:21 +02:00
0d56acfbaa
macOS's ranlib issued a warning about an empty pread.o file with the previous arrangement, on systems new enough to require no replacement functions. Let's go back to using configure's AC_REPLACE_FUNCS system to build and include each .o in the library only if it's needed, which requires moving the *v() functions to their own files. Also move the _with_retry() wrapper to a more permanent home. Reported-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/1283127.1610554395%40sss.pgh.pa.us |
||
---|---|---|
.. | ||
.gitignore | ||
chklocale.c | ||
dirent.c | ||
dirmod.c | ||
dlopen.c | ||
erand48.c | ||
explicit_bzero.c | ||
fls.c | ||
getaddrinfo.c | ||
getopt_long.c | ||
getopt.c | ||
getpeereid.c | ||
getrusage.c | ||
gettimeofday.c | ||
inet_aton.c | ||
inet_net_ntop.c | ||
kill.c | ||
link.c | ||
Makefile | ||
mkdtemp.c | ||
noblock.c | ||
open.c | ||
path.c | ||
pg_bitutils.c | ||
pg_crc32c_armv8_choose.c | ||
pg_crc32c_armv8.c | ||
pg_crc32c_sb8.c | ||
pg_crc32c_sse42_choose.c | ||
pg_crc32c_sse42.c | ||
pg_strong_random.c | ||
pgcheckdir.c | ||
pgmkdirp.c | ||
pgsleep.c | ||
pgstrcasecmp.c | ||
pgstrsignal.c | ||
pqsignal.c | ||
pread.c | ||
preadv.c | ||
pthread-win32.h | ||
pwrite.c | ||
pwritev.c | ||
qsort_arg.c | ||
qsort.c | ||
quotes.c | ||
random.c | ||
README | ||
setenv.c | ||
snprintf.c | ||
srandom.c | ||
strerror.c | ||
strlcat.c | ||
strlcpy.c | ||
strnlen.c | ||
strtof.c | ||
system.c | ||
tar.c | ||
thread.c | ||
unsetenv.c | ||
win32.ico | ||
win32env.c | ||
win32error.c | ||
win32security.c | ||
win32setlocale.c | ||
win32stat.c | ||
win32ver.rc |
src/port/README libpgport ========= libpgport must have special behavior. It supplies functions to both libraries and applications. However, there are two complexities: 1) Libraries need to use object files that are compiled with exactly the same flags as the library. libpgport might not use the same flags, so it is necessary to recompile the object files for individual libraries. This is done by removing -lpgport from the link line: # Need to recompile any libpgport object files LIBS := $(filter-out -lpgport, $(LIBS)) and adding infrastructure to recompile the object files: OBJS= execute.o typename.o descriptor.o data.o error.o prepare.o memory.o \ connect.o misc.o path.o exec.o \ $(filter strlcat.o, $(LIBOBJS)) The problem is that there is no testing of which object files need to be added, but missing functions usually show up when linking user applications. 2) For applications, we use -lpgport before -lpq, so the static files from libpgport are linked first. This avoids having applications dependent on symbols that are _used_ by libpq, but not intended to be exported by libpq. libpq's libpgport usage changes over time, so such a dependency is a problem. Windows, Linux, and macOS use an export list to control the symbols exported by libpq.