Tom Lane 0fae846232 Fix some minor postmaster-state-machine issues. ... In sigusr1_handler, don't ignore PMSIGNAL_ADVANCE_STATE_MACHINE based on pmState. The restriction is unnecessary (PostmasterStateMachine should work in any state), not future-proof (since it makes too many assumptions about why the signal might be sent), and broken even today because a race condition can make it necessary to respond to the signal in PM_WAIT_READONLY state. The race condition seems unlikely, but if it did happen, a hot-standby postmaster could fail to shut down after receiving a smart-shutdown request. In MaybeStartWalReceiver, don't clear the WalReceiverRequested flag if the fork attempt fails. Leaving it set allows us to try again in future iterations of the postmaster idle loop. (The startup process would eventually send a fresh request signal, but this change may allow us to retry the fork sooner.) Remove an obsolete comment and unnecessary test in PostmasterStateMachine's handling of PM_SHUTDOWN_2 state. It's not possible to have a live walreceiver in that state, and AFAICT has not been possible since commit 5e85315ea. This isn't a live bug, but the false comment is quite confusing to readers. In passing, rearrange sigusr1_handler's CheckPromoteSignal tests so that we don't uselessly perform stat() calls that we're going to ignore the results of. Add some comments clarifying the behavior of MaybeStartWalReceiver; I very nearly rearranged it in a way that'd reintroduce the race condition fixed in e5d494d78. Mea culpa for not commenting that properly at the time. Back-patch to all supported branches. The PMSIGNAL_ADVANCE_STATE_MACHINE change is the only one of even minor significance, but we might as well keep this code in sync across branches. Discussion: https://postgr.es/m/9001.1556046681@sss.pgh.pa.us		2019-04-24 14:15:44 -04:00
..
backend	Fix some minor postmaster-state-machine issues.	2019-04-24 14:15:44 -04:00
bin	pg_dump: Remove stray option parsing support for -o.	2019-04-17 17:28:02 -07:00
common	Add support for partial TOAST decompression	2019-04-02 12:35:32 -04:00
fe_utils	Ensure consistent name matching behavior in processSQLNamePattern().	2019-04-05 12:59:57 -04:00
include	Allow pg_class xid & multixid horizons to not be set.	2019-04-23 21:42:12 -07:00
interfaces	GSSAPI: Improve documentation and tests	2019-04-19 21:22:22 -04:00
makefiles	Define WIN32_STACK_RLIMIT throughout win32 and cygwin builds.	2019-04-09 08:25:39 -07:00
pl	Fix problems with auto-held portals.	2019-04-19 11:20:37 -04:00
port	Assert that pgwin32_signal_initialize() has been called early enough.	2019-04-03 17:11:16 -07:00
template	Yet further rethinking of build changes for macOS Mojave.	2018-11-02 18:54:00 -04:00
test	Repair assorted issues in locale data extraction.	2019-04-23 18:51:30 -04:00
timezone	More unconstify use	2019-02-13 11:50:16 +01:00
tools	Consistently test for in-use shared memory.	2019-04-12 22:36:38 -07:00
tutorial	SQL comment: remove extra word in heading comment	2019-01-25 18:57:21 -05:00
.gitignore
DEVELOPERS
Makefile	Fix partial-build problems introduced by having more generated headers.	2018-04-09 16:42:10 -04:00
Makefile.global.in	Consistently test for in-use shared memory.	2019-04-12 22:36:38 -07:00
Makefile.shlib	Ensure static libraries have correct mod time even if ranlib messes it up.	2018-11-29 15:53:44 -05:00
nls-global.mk	Unified logging system for command-line programs	2019-04-01 20:01:35 +02:00