mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-07-18 11:41:13 +02:00
de2aca2885
This commit adds more coverage for utility statements so as it is possible to track down all the effects of query normalization done for all the queries that use either Const or A_Const nodes, which are the nodes where normalization makes the most sense as they apply to constants (well, most of the time, really). This set of queries is extracted from an analysis done while looking at full dumps of the regression database when applying different levels of normalization to either Const or A_Const nodes for utilities, as of a minimal set of these, for: - All relkinds (CREATE, ALTER, DROP) - Policies - Cursors - Triggers - Types - Rules - Statistics - CALL - Transaction statements (isolation level, options) - EXPLAIN - COPY Note that pg_stat_statements is not switched yet to show any normalization for utilities, still it improves the default coverage of the query jumbling code (not by as much as enabling query jumbling on the main regression test suite, though): - queryjumblefuncs.funcs.c: 36.8% => 48.5% - queryjumblefuncs.switch.c: 33.2% => 43.1% Reviewed-by: Bertrand Drouvot Discussion: https://postgr.es/m/Y+MRdEq9W9XVa2AB@paquier.xyz
31 lines
798 B
PL/PgSQL
31 lines
798 B
PL/PgSQL
--
|
|
-- Cursors
|
|
--
|
|
|
|
-- These tests require track_utility to be enabled.
|
|
SET pg_stat_statements.track_utility = TRUE;
|
|
SELECT pg_stat_statements_reset();
|
|
|
|
-- DECLARE
|
|
-- SELECT is normalized.
|
|
DECLARE cursor_stats_1 CURSOR WITH HOLD FOR SELECT 1;
|
|
CLOSE cursor_stats_1;
|
|
DECLARE cursor_stats_1 CURSOR WITH HOLD FOR SELECT 2;
|
|
CLOSE cursor_stats_1;
|
|
|
|
SELECT calls, rows, query FROM pg_stat_statements ORDER BY query COLLATE "C";
|
|
SELECT pg_stat_statements_reset();
|
|
|
|
-- FETCH
|
|
BEGIN;
|
|
DECLARE cursor_stats_1 CURSOR WITH HOLD FOR SELECT 2;
|
|
DECLARE cursor_stats_2 CURSOR WITH HOLD FOR SELECT 3;
|
|
FETCH 1 IN cursor_stats_1;
|
|
FETCH 1 IN cursor_stats_2;
|
|
CLOSE cursor_stats_1;
|
|
CLOSE cursor_stats_2;
|
|
COMMIT;
|
|
|
|
SELECT calls, rows, query FROM pg_stat_statements ORDER BY query COLLATE "C";
|
|
SELECT pg_stat_statements_reset();
|