Tom Lane 12cb7ea599 Repair bogus EPQ plans generated for postgres_fdw foreign joins. ... postgres_fdw's postgresGetForeignPlan() assumes without checking that the outer_plan it's given for a join relation must have a NestLoop, MergeJoin, or HashJoin node at the top. That's been wrong at least since commit 4bbf6edfb (which could cause insertion of a Sort node on top) and it seems like a pretty unsafe thing to Just Assume even without that. Through blind good fortune, this doesn't seem to have any worse consequences today than strange EXPLAIN output, but it's clearly trouble waiting to happen. To fix, test the node type explicitly before touching Join-specific fields, and avoid jamming the new tlist into a node type that can't do projection. Export a new support function from createplan.c to avoid building low-level knowledge about the latter into FDWs. Back-patch to 9.6 where the faulty coding was added. Note that the associated regression test cases don't show any changes before v11, apparently because the tests back-patched with 4bbf6edfb don't actually exercise the problem case before then (there's no top-level Sort in those plans). Discussion: https://postgr.es/m/8946.1544644803@sss.pgh.pa.us		2018-12-12 16:08:30 -05:00
..
backend	Repair bogus EPQ plans generated for postgres_fdw foreign joins.	2018-12-12 16:08:30 -05:00
bin	Fix ac218aa4f6 to work on versions before 9.5.	2018-11-26 23:26:24 -08:00
common	Improve our response to invalid format strings, and detect more cases.	2018-12-06 15:08:44 -05:00
fe_utils	Fix translation of special characters in psql's LaTeX output modes.	2018-11-26 17:32:51 -05:00
include	Repair bogus EPQ plans generated for postgres_fdw foreign joins.	2018-12-12 16:08:30 -05:00
interfaces	Second try at fixing numeric data passed through an ECPG SQLDA.	2018-11-14 11:27:31 -05:00
makefiles	Prevent accidental linking of system-supplied copies of libpq.so etc.	2018-07-09 17:23:31 -04:00
pl	Still further rethinking of build changes for macOS Mojave.	2018-10-18 14:55:23 -04:00
port	Stamp 9.6.11.	2018-11-05 16:47:37 -05:00
template	Yet further rethinking of build changes for macOS Mojave.	2018-11-02 18:54:00 -04:00
test	Repair bogus handling of multi-assignment Params in upper plan levels.	2018-12-12 13:49:42 -05:00
timezone	Sync our copy of the timezone library with IANA release tzcode2018g.	2018-10-31 09:48:14 -04:00
tools	Add valgrind suppressions for wcsrtombs optimizations	2018-11-18 00:09:16 +01:00
tutorial	Update copyright for 2016	2016-01-02 13:33:40 -05:00
.gitignore
bcc32.mak
DEVELOPERS
Makefile	Install TAP test infrastructure so it's available for extension testing.	2016-09-23 15:50:00 -04:00
Makefile.global.in	Yet further rethinking of build changes for macOS Mojave.	2018-11-02 18:54:00 -04:00
Makefile.shlib	Ensure static libraries have correct mod time even if ranlib messes it up.	2018-11-29 15:53:44 -05:00
nls-global.mk	nls-global.mk: search build dir for source files, too	2016-06-07 18:55:18 -04:00
win32.mak