mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-07-14 16:39:17 +02:00
8d1c1ca70b
Change a whole-database VACUUM into doing just pg_attribute, which is the portion that verifies what we want it to do. The original formulation wastes a lot of CPU time, which leads the test to fail when runtime exceeds isolationtester timeout when it's super-slow, such as under CLOBBER_CACHE_ALWAYS. Per buildfarm member friarbird. It turns out that the previous shape of the test doesn't always detect the condition it is supposed to detect (on unpatched reorderbuffer code): the reason is that there is a good chance of encountering a xl_running_xacts record (logged every 15 seconds) before the checkpoint -- and because we advance the xmin when we receive that WAL record, and we *don't* advance the xmin twice consecutively without receiving a client message in between, that means the xmin is not advanced enough for the tuple to be pruned from pg_attribute by VACUUM. So the test would spuriously pass. The reason this test deficiency wasn't detected earlier is that HOT pruning removes the tuple anyway, even if vacuum leaves it in place, so the test correctly fails (detecting the coding mistake), but for the wrong reason. To fix this mess, run the s0_get_changes step twice before vacuum instead of once: this seems to cause the xmin to be advanced reliably, wreaking havoc with more certainty. Author: Arseny Sher Discussion: https://postgr.es/m/87h8lkuxoa.fsf@ars-thinkpad
31 lines
1.1 KiB
Plaintext
31 lines
1.1 KiB
Plaintext
Parsed test spec with 2 sessions
|
|
|
|
starting permutation: s0_begin s0_getxid s1_begin s1_insert s0_alter s0_commit s0_checkpoint s0_get_changes s0_get_changes s1_commit s0_vacuum s0_get_changes
|
|
step s0_begin: BEGIN;
|
|
step s0_getxid: SELECT txid_current() IS NULL;
|
|
?column?
|
|
|
|
f
|
|
step s1_begin: BEGIN;
|
|
step s1_insert: INSERT INTO harvest VALUES ((1, 2, 3));
|
|
step s0_alter: ALTER TYPE basket DROP ATTRIBUTE mangos;
|
|
step s0_commit: COMMIT;
|
|
step s0_checkpoint: CHECKPOINT;
|
|
step s0_get_changes: SELECT data FROM pg_logical_slot_get_changes('isolation_slot', NULL, NULL, 'include-xids', '0', 'skip-empty-xacts', '1');
|
|
data
|
|
|
|
step s0_get_changes: SELECT data FROM pg_logical_slot_get_changes('isolation_slot', NULL, NULL, 'include-xids', '0', 'skip-empty-xacts', '1');
|
|
data
|
|
|
|
step s1_commit: COMMIT;
|
|
step s0_vacuum: VACUUM pg_attribute;
|
|
step s0_get_changes: SELECT data FROM pg_logical_slot_get_changes('isolation_slot', NULL, NULL, 'include-xids', '0', 'skip-empty-xacts', '1');
|
|
data
|
|
|
|
BEGIN
|
|
table public.harvest: INSERT: fruits[basket]:'(1,2,3)'
|
|
COMMIT
|
|
?column?
|
|
|
|
stop
|