mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-07-27 10:25:32 +02:00
1731e3741c
We want, say, 2 to be transformed as 2, not \\2 which is what the original coding produced. Perl's standard seems to be to add an RV wrapper only for hash and array SVs, so do it like that. This was missed originally because the test cases only checked what came out of a round trip back to SQL, and the strip-all-dereferences loop at the top of SV_to_JsonbValue hides the extra refs from view. As a better test, print the Perl value with Data::Dumper, like the hstore_plperlu tests do. While we can't do that in the plperl test, only plperlu, that should be good enough because this code is the same for both PLs. But also add a simplistic test for extra REFs, which we can do in both. That strip-all-dereferences behavior is now a bit dubious; it's unlike what happens for other Perl-to-SQL conversions. However, the best thing to do seems to be to leave it alone and make the other conversions act similarly. That will be done separately. Dagfinn Ilmari Mannsåker, adjusted a bit by me Discussion: https://postgr.es/m/d8jlgbq66t9.fsf@dalvik.ping.uio.no
96 lines
2.1 KiB
PL/PgSQL
96 lines
2.1 KiB
PL/PgSQL
CREATE EXTENSION jsonb_plperlu CASCADE;
|
|
|
|
|
|
CREATE FUNCTION testHVToJsonb() RETURNS jsonb
|
|
LANGUAGE plperlu
|
|
TRANSFORM FOR TYPE jsonb
|
|
AS $$
|
|
$val = {a => 1, b => 'boo', c => undef};
|
|
return $val;
|
|
$$;
|
|
|
|
SELECT testHVToJsonb();
|
|
|
|
|
|
CREATE FUNCTION testAVToJsonb() RETURNS jsonb
|
|
LANGUAGE plperlu
|
|
TRANSFORM FOR TYPE jsonb
|
|
AS $$
|
|
$val = [{a => 1, b => 'boo', c => undef}, {d => 2}];
|
|
return $val;
|
|
$$;
|
|
|
|
SELECT testAVToJsonb();
|
|
|
|
|
|
CREATE FUNCTION testSVToJsonb() RETURNS jsonb
|
|
LANGUAGE plperlu
|
|
TRANSFORM FOR TYPE jsonb
|
|
AS $$
|
|
$val = 1;
|
|
return $val;
|
|
$$;
|
|
|
|
SELECT testSVToJsonb();
|
|
|
|
|
|
-- this revealed a bug in the original implementation
|
|
CREATE FUNCTION testRegexpResultToJsonb() RETURNS jsonb
|
|
LANGUAGE plperlu
|
|
TRANSFORM FOR TYPE jsonb
|
|
AS $$
|
|
return ('1' =~ m(0\t2));
|
|
$$;
|
|
|
|
SELECT testRegexpResultToJsonb();
|
|
|
|
|
|
CREATE FUNCTION roundtrip(val jsonb, ref text = '') RETURNS jsonb
|
|
LANGUAGE plperlu
|
|
TRANSFORM FOR TYPE jsonb
|
|
AS $$
|
|
use Data::Dumper;
|
|
$Data::Dumper::Sortkeys = 1;
|
|
$Data::Dumper::Indent = 0;
|
|
elog(INFO, Dumper($_[0]));
|
|
die 'unexpected '.(ref($_[0]) || 'not a').' reference'
|
|
if ref($_[0]) ne $_[1];
|
|
return $_[0];
|
|
$$;
|
|
|
|
|
|
SELECT roundtrip('null') is null;
|
|
SELECT roundtrip('1');
|
|
SELECT roundtrip('1E+131071');
|
|
SELECT roundtrip('-1');
|
|
SELECT roundtrip('1.2');
|
|
SELECT roundtrip('-1.2');
|
|
SELECT roundtrip('"string"');
|
|
SELECT roundtrip('"NaN"');
|
|
|
|
SELECT roundtrip('true');
|
|
SELECT roundtrip('false');
|
|
|
|
SELECT roundtrip('[]', 'ARRAY');
|
|
SELECT roundtrip('[null, null]', 'ARRAY');
|
|
SELECT roundtrip('[1, 2, 3]', 'ARRAY');
|
|
SELECT roundtrip('[-1, 2, -3]', 'ARRAY');
|
|
SELECT roundtrip('[1.2, 2.3, 3.4]', 'ARRAY');
|
|
SELECT roundtrip('[-1.2, 2.3, -3.4]', 'ARRAY');
|
|
SELECT roundtrip('["string1", "string2"]', 'ARRAY');
|
|
SELECT roundtrip('[["string1", "string2"]]', 'ARRAY');
|
|
|
|
SELECT roundtrip('{}', 'HASH');
|
|
SELECT roundtrip('{"1": null}', 'HASH');
|
|
SELECT roundtrip('{"1": 1}', 'HASH');
|
|
SELECT roundtrip('{"1": -1}', 'HASH');
|
|
SELECT roundtrip('{"1": 1.1}', 'HASH');
|
|
SELECT roundtrip('{"1": -1.1}', 'HASH');
|
|
SELECT roundtrip('{"1": "string1"}', 'HASH');
|
|
|
|
SELECT roundtrip('{"1": {"2": [3, 4, 5]}, "2": 3}', 'HASH');
|
|
|
|
|
|
\set VERBOSITY terse \\ -- suppress cascade details
|
|
DROP EXTENSION plperlu CASCADE;
|