postgresql/src/bin/pg_dump
Noah Misch 582edc369c Empty search_path in Autovacuum and non-psql/pgbench clients.
This makes the client programs behave as documented regardless of the
connect-time search_path and regardless of user-created objects.  Today,
a malicious user with CREATE permission on a search_path schema can take
control of certain of these clients' queries and invoke arbitrary SQL
functions under the client identity, often a superuser.  This is
exploitable in the default configuration, where all users have CREATE
privilege on schema "public".

This changes behavior of user-defined code stored in the database, like
pg_index.indexprs and pg_extension_config_dump().  If they reach code
bearing unqualified names, "does not exist" or "no schema has been
selected to create in" errors might appear.  Users may fix such errors
by schema-qualifying affected names.  After upgrading, consider watching
server logs for these errors.

The --table arguments of src/bin/scripts clients have been lax; for
example, "vacuumdb -Zt pg_am\;CHECKPOINT" performed a checkpoint.  That
now fails, but for now, "vacuumdb -Zt 'pg_am(amname);CHECKPOINT'" still
performs a checkpoint.

Back-patch to 9.3 (all supported versions).

Reviewed by Tom Lane, though this fix strategy was not his first choice.
Reported by Arseniy Sharoglazov.

Security: CVE-2018-1058
2018-02-26 07:39:44 -08:00
..
po Translation updates 2017-08-07 13:55:34 -04:00
t Avoid using unsafe search_path settings during dump and restore. 2018-02-26 10:18:21 -05:00
.gitignore Clean up after pg_dump test runs. 2016-05-06 22:28:01 -04:00
Makefile Update copyright for 2018 2018-01-02 23:30:12 -05:00
common.c Fix assorted errors in pg_dump's handling of extended statistics objects. 2018-02-11 13:24:15 -05:00
compress_io.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
compress_io.h Update copyright for 2018 2018-01-02 23:30:12 -05:00
dumputils.c Avoid using unsafe search_path settings during dump and restore. 2018-02-26 10:18:21 -05:00
dumputils.h Avoid using unsafe search_path settings during dump and restore. 2018-02-26 10:18:21 -05:00
nls.mk Translation updates 2017-08-07 13:55:34 -04:00
parallel.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
parallel.h Update copyright for 2018 2018-01-02 23:30:12 -05:00
pg_backup.h Avoid using unsafe search_path settings during dump and restore. 2018-02-26 10:18:21 -05:00
pg_backup_archiver.c Avoid using unsafe search_path settings during dump and restore. 2018-02-26 10:18:21 -05:00
pg_backup_archiver.h Avoid using unsafe search_path settings during dump and restore. 2018-02-26 10:18:21 -05:00
pg_backup_custom.c Phase 3 of pgindent updates. 2017-06-21 15:35:54 -04:00
pg_backup_db.c Empty search_path in Autovacuum and non-psql/pgbench clients. 2018-02-26 07:39:44 -08:00
pg_backup_db.h Add some const decorations to prototypes 2017-11-10 13:38:57 -05:00
pg_backup_directory.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
pg_backup_null.c Reduce excessive dereferencing of function pointers 2017-09-07 13:56:09 -04:00
pg_backup_tar.c Final pgindent + perltidy run for v10. 2017-08-14 17:29:33 -04:00
pg_backup_tar.h Fix tar files emitted by pg_dump and pg_basebackup to be POSIX conformant. 2012-09-28 15:19:15 -04:00
pg_backup_utils.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
pg_backup_utils.h Update copyright for 2018 2018-01-02 23:30:12 -05:00
pg_dump.c Empty search_path in Autovacuum and non-psql/pgbench clients. 2018-02-26 07:39:44 -08:00
pg_dump.h Fix assorted errors in pg_dump's handling of extended statistics objects. 2018-02-11 13:24:15 -05:00
pg_dump_sort.c Local partitioned indexes 2018-01-19 11:49:22 -03:00
pg_dumpall.c Empty search_path in Autovacuum and non-psql/pgbench clients. 2018-02-26 07:39:44 -08:00
pg_restore.c Support --no-comments in pg_dump, pg_dumpall, pg_restore. 2018-01-25 15:27:24 -05:00