mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-09-06 23:59:21 +02:00
There are basically three situations in which logical decoding needs
to perform cache invalidation. During/After replaying a transaction
with catalog changes, when skipping a uninteresting transaction that
performed catalog changes and when erroring out while replaying a
transaction. Unfortunately these three cases were all done slightly
differently - partially because 8de3e410fa
, which greatly simplifies
matters, got committed in the midst of the development of logical
decoding.
The actually problematic case was when logical decoding skipped
transaction commits (and thus processed invalidations). When used via
the SQL interface cache invalidation could access the catalog - bad,
because we didn't set up enough state to allow that correctly. It'd
not be hard to setup sufficient state, but the simpler solution is to
always perform cache invalidation outside a valid transaction.
Also make the different cache invalidation cases look as similar as
possible, to ease code review.
This fixes the assertion failure reported by Antonin Houska in
53EE02D9.7040702@gmail.com. The presented testcase has been expanded
into a regression test.
Backpatch to 9.4, where logical decoding was introduced.
74 lines
2.4 KiB
Makefile
74 lines
2.4 KiB
Makefile
# contrib/test_decoding/Makefile
|
|
|
|
MODULES = test_decoding
|
|
PGFILEDESC = "test_decoding - example of a logical decoding output plugin"
|
|
|
|
# Note: because we don't tell the Makefile there are any regression tests,
|
|
# we have to clean those result files explicitly
|
|
EXTRA_CLEAN = $(pg_regress_clean_files) ./regression_output ./isolation_output
|
|
|
|
ifdef USE_PGXS
|
|
PG_CONFIG = pg_config
|
|
PGXS := $(shell $(PG_CONFIG) --pgxs)
|
|
include $(PGXS)
|
|
else
|
|
subdir = contrib/test_decoding
|
|
top_builddir = ../..
|
|
include $(top_builddir)/src/Makefile.global
|
|
include $(top_srcdir)/contrib/contrib-global.mk
|
|
endif
|
|
|
|
# Disabled because these tests require "wal_level=logical", which
|
|
# typical installcheck users do not have (e.g. buildfarm clients).
|
|
installcheck:;
|
|
|
|
# But it can nonetheless be very helpful to run tests on preexisting
|
|
# installation, allow to do so, but only if requested explicitly.
|
|
installcheck-force: regresscheck-install-force isolationcheck-install-force
|
|
|
|
check: regresscheck isolationcheck
|
|
|
|
submake-regress:
|
|
$(MAKE) -C $(top_builddir)/src/test/regress all
|
|
|
|
submake-isolation:
|
|
$(MAKE) -C $(top_builddir)/src/test/isolation all
|
|
|
|
submake-test_decoding:
|
|
$(MAKE) -C $(top_builddir)/contrib/test_decoding
|
|
|
|
REGRESSCHECKS=ddl rewrite toast permissions decoding_in_xact decoding_into_rel binary prepared
|
|
|
|
regresscheck: all | submake-regress submake-test_decoding
|
|
$(MKDIR_P) regression_output
|
|
$(pg_regress_check) \
|
|
--temp-config $(top_srcdir)/contrib/test_decoding/logical.conf \
|
|
--temp-install=./tmp_check \
|
|
--extra-install=contrib/test_decoding \
|
|
--outputdir=./regression_output \
|
|
$(REGRESSCHECKS)
|
|
|
|
regresscheck-install-force: | submake-regress submake-test_decoding
|
|
$(pg_regress_installcheck) \
|
|
--extra-install=contrib/test_decoding \
|
|
$(REGRESSCHECKS)
|
|
|
|
ISOLATIONCHECKS=mxact delayed_startup ondisk_startup concurrent_ddl_dml
|
|
|
|
isolationcheck: all | submake-isolation submake-test_decoding
|
|
$(MKDIR_P) isolation_output
|
|
$(pg_isolation_regress_check) \
|
|
--temp-config $(top_srcdir)/contrib/test_decoding/logical.conf \
|
|
--extra-install=contrib/test_decoding \
|
|
--outputdir=./isolation_output \
|
|
$(ISOLATIONCHECKS)
|
|
|
|
isolationcheck-install-force: all | submake-isolation submake-test_decoding
|
|
$(pg_isolation_regress_installcheck) \
|
|
--extra-install=contrib/test_decoding \
|
|
$(ISOLATIONCHECKS)
|
|
|
|
PHONY: submake-test_decoding submake-regress check \
|
|
regresscheck regresscheck-install-force \
|
|
isolationcheck isolationcheck-install-force
|