mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-08-21 06:03:22 +02:00
1b86c81d2d
When decoding the results of a HEAP2_MULTI_INSERT (currently only generated by COPY FROM) toast columns for all but the last tuple weren't replaced by their actual contents before being handed to the output plugin. The reassembled toast datums where disregarded after every REORDER_BUFFER_CHANGE_(INSERT|UPDATE|DELETE) which is correct for plain inserts, updates, deletes, but not multi inserts - there we generate several REORDER_BUFFER_CHANGE_INSERTs for a single xl_heap_multi_insert record. To solve the problem add a clear_toast_afterwards boolean to ReorderBufferChange's union member that's used by modifications. All row changes but multi_inserts always set that to true, but multi_insert sets it only for the last change generated. Add a regression test covering decoding of multi_inserts - there was none at all before. Backpatch to 9.4 where logical decoding was introduced. Bug found by Petr Jelinek.
109 lines
5.1 KiB
Plaintext
109 lines
5.1 KiB
Plaintext
-- predictability
|
|
SET synchronous_commit = on;
|
|
DROP TABLE IF EXISTS xpto;
|
|
NOTICE: table "xpto" does not exist, skipping
|
|
SELECT 'init' FROM pg_create_logical_replication_slot('regression_slot', 'test_decoding');
|
|
?column?
|
|
----------
|
|
init
|
|
(1 row)
|
|
|
|
CREATE SEQUENCE xpto_rand_seq START 79 INCREMENT 1499; -- portable "random"
|
|
CREATE TABLE xpto (
|
|
id serial primary key,
|
|
toasted_col1 text,
|
|
rand1 float8 DEFAULT nextval('xpto_rand_seq'),
|
|
toasted_col2 text,
|
|
rand2 float8 DEFAULT nextval('xpto_rand_seq')
|
|
);
|
|
-- uncompressed external toast data
|
|
INSERT INTO xpto (toasted_col1, toasted_col2) SELECT string_agg(g.i::text, ''), string_agg((g.i*2)::text, '') FROM generate_series(1, 2000) g(i);
|
|
-- compressed external toast data
|
|
INSERT INTO xpto (toasted_col2) SELECT repeat(string_agg(to_char(g.i, 'FM0000'), ''), 50) FROM generate_series(1, 500) g(i);
|
|
-- update of existing column
|
|
UPDATE xpto SET toasted_col1 = (SELECT string_agg(g.i::text, '') FROM generate_series(1, 2000) g(i)) WHERE id = 1;
|
|
UPDATE xpto SET rand1 = 123.456 WHERE id = 1;
|
|
DELETE FROM xpto WHERE id = 1;
|
|
DROP TABLE IF EXISTS toasted_key;
|
|
NOTICE: table "toasted_key" does not exist, skipping
|
|
CREATE TABLE toasted_key (
|
|
id serial,
|
|
toasted_key text PRIMARY KEY,
|
|
toasted_col1 text,
|
|
toasted_col2 text
|
|
);
|
|
ALTER TABLE toasted_key ALTER COLUMN toasted_key SET STORAGE EXTERNAL;
|
|
ALTER TABLE toasted_key ALTER COLUMN toasted_col1 SET STORAGE EXTERNAL;
|
|
INSERT INTO toasted_key(toasted_key, toasted_col1) VALUES(repeat('1234567890', 200), repeat('9876543210', 200));
|
|
-- test update of a toasted key without changing it
|
|
UPDATE toasted_key SET toasted_col2 = toasted_col1;
|
|
-- test update of a toasted key, changing it
|
|
UPDATE toasted_key SET toasted_key = toasted_key || '1';
|
|
DELETE FROM toasted_key;
|
|
-- Test that HEAP2_MULTI_INSERT insertions with and without toasted
|
|
-- columns are handled correctly
|
|
CREATE TABLE toasted_copy (
|
|
id int primary key, -- no default, copy didn't use to handle that with multi inserts
|
|
data text
|
|
);
|
|
ALTER TABLE toasted_copy ALTER COLUMN data SET STORAGE EXTERNAL;
|
|
\copy toasted_copy FROM STDIN
|
|
SELECT substr(data, 1, 200) FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'include-xids', '0');
|
|
substr
|
|
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
|
|
BEGIN
|
|
COMMIT
|
|
BEGIN
|
|
COMMIT
|
|
BEGIN
|
|
table public.xpto: INSERT: id[integer]:1 toasted_col1[text]:'1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374
|
|
COMMIT
|
|
BEGIN
|
|
table public.xpto: INSERT: id[integer]:2 toasted_col1[text]:null rand1[double precision]:3077 toasted_col2[text]:'00010002000300040005000600070008000900100011001200130014001500160017001800190020002100
|
|
COMMIT
|
|
BEGIN
|
|
table public.xpto: UPDATE: id[integer]:1 toasted_col1[text]:'1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374
|
|
COMMIT
|
|
BEGIN
|
|
table public.xpto: UPDATE: id[integer]:1 toasted_col1[text]:unchanged-toast-datum rand1[double precision]:123.456 toasted_col2[text]:unchanged-toast-datum rand2[double precision]:1578
|
|
COMMIT
|
|
BEGIN
|
|
table public.xpto: DELETE: id[integer]:1
|
|
COMMIT
|
|
BEGIN
|
|
COMMIT
|
|
BEGIN
|
|
COMMIT
|
|
BEGIN
|
|
COMMIT
|
|
BEGIN
|
|
table public.toasted_key: INSERT: id[integer]:1 toasted_key[text]:'1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123
|
|
COMMIT
|
|
BEGIN
|
|
table public.toasted_key: UPDATE: id[integer]:1 toasted_key[text]:unchanged-toast-datum toasted_col1[text]:unchanged-toast-datum toasted_col2[text]:'987654321098765432109876543210987654321098765432109
|
|
COMMIT
|
|
BEGIN
|
|
table public.toasted_key: UPDATE: old-key: toasted_key[text]:'123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678
|
|
COMMIT
|
|
BEGIN
|
|
table public.toasted_key: DELETE: toasted_key[text]:'123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567
|
|
COMMIT
|
|
BEGIN
|
|
COMMIT
|
|
BEGIN
|
|
COMMIT
|
|
BEGIN
|
|
table public.toasted_copy: INSERT: id[integer]:1 data[text]:'untoasted1'
|
|
table public.toasted_copy: INSERT: id[integer]:2 data[text]:'toasted1-1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890
|
|
table public.toasted_copy: INSERT: id[integer]:3 data[text]:'untoasted2'
|
|
table public.toasted_copy: INSERT: id[integer]:4 data[text]:'toasted2-1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890
|
|
COMMIT
|
|
(47 rows)
|
|
|
|
SELECT pg_drop_replication_slot('regression_slot');
|
|
pg_drop_replication_slot
|
|
--------------------------
|
|
|
|
(1 row)
|
|
|