mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-07-15 18:41:10 +02:00
cd4868a570
Getting from get_raw_page() an all-zero page is considered as a valid case by the buffer manager and it can happen for example when finding a corrupted page with zero_damaged_pages enabled (using zero_damaged_pages to look at corrupted pages happens), or after a crash when a relation file is extended before any WAL for its new data is generated (before a vacuum or autovacuum job comes in to do some cleanup). However, all the functions of pageinspect, as of the index AMs (except hash that has its own idea of new pages), heap, the FSM or the page header have never worked with all-zero pages, causing various crashes when going through the page internals. This commit changes all the pageinspect functions to be compliant with all-zero pages, where the choice is made to return NULL or no rows for SRFs when finding a new page. get_raw_page() still works the same way, returning a batch of zeros in the bytea of the page retrieved. A hard error could be used but NULL, while more invasive, is useful when scanning relation files in full to get a batch of results for a single relation in one query. Tests are added for all the code paths impacted. Reported-by: Daria Lepikhova Author: Michael Paquier Discussion: https://postgr.es/m/561e187b-3549-c8d5-03f5-525c14e65bd0@postgrespro.ru Backpatch-through: 10
109 lines
4.6 KiB
SQL
109 lines
4.6 KiB
SQL
CREATE TABLE test_hash (a int, b text);
|
|
INSERT INTO test_hash VALUES (1, 'one');
|
|
CREATE INDEX test_hash_a_idx ON test_hash USING hash (a);
|
|
|
|
\x
|
|
|
|
SELECT hash_page_type(get_raw_page('test_hash_a_idx', 0));
|
|
SELECT hash_page_type(get_raw_page('test_hash_a_idx', 1));
|
|
SELECT hash_page_type(get_raw_page('test_hash_a_idx', 2));
|
|
SELECT hash_page_type(get_raw_page('test_hash_a_idx', 3));
|
|
SELECT hash_page_type(get_raw_page('test_hash_a_idx', 4));
|
|
SELECT hash_page_type(get_raw_page('test_hash_a_idx', 5));
|
|
SELECT hash_page_type(get_raw_page('test_hash_a_idx', 6));
|
|
|
|
|
|
SELECT * FROM hash_bitmap_info('test_hash_a_idx', -1);
|
|
SELECT * FROM hash_bitmap_info('test_hash_a_idx', 0);
|
|
SELECT * FROM hash_bitmap_info('test_hash_a_idx', 1);
|
|
SELECT * FROM hash_bitmap_info('test_hash_a_idx', 2);
|
|
SELECT * FROM hash_bitmap_info('test_hash_a_idx', 3);
|
|
SELECT * FROM hash_bitmap_info('test_hash_a_idx', 4);
|
|
SELECT * FROM hash_bitmap_info('test_hash_a_idx', 5);
|
|
SELECT * FROM hash_bitmap_info('test_hash_a_idx', 6);
|
|
|
|
|
|
SELECT magic, version, ntuples, bsize, bmsize, bmshift, maxbucket, highmask,
|
|
lowmask, ovflpoint, firstfree, nmaps, procid, spares, mapp FROM
|
|
hash_metapage_info(get_raw_page('test_hash_a_idx', 0));
|
|
|
|
SELECT magic, version, ntuples, bsize, bmsize, bmshift, maxbucket, highmask,
|
|
lowmask, ovflpoint, firstfree, nmaps, procid, spares, mapp FROM
|
|
hash_metapage_info(get_raw_page('test_hash_a_idx', 1));
|
|
|
|
SELECT magic, version, ntuples, bsize, bmsize, bmshift, maxbucket, highmask,
|
|
lowmask, ovflpoint, firstfree, nmaps, procid, spares, mapp FROM
|
|
hash_metapage_info(get_raw_page('test_hash_a_idx', 2));
|
|
|
|
SELECT magic, version, ntuples, bsize, bmsize, bmshift, maxbucket, highmask,
|
|
lowmask, ovflpoint, firstfree, nmaps, procid, spares, mapp FROM
|
|
hash_metapage_info(get_raw_page('test_hash_a_idx', 3));
|
|
|
|
SELECT magic, version, ntuples, bsize, bmsize, bmshift, maxbucket, highmask,
|
|
lowmask, ovflpoint, firstfree, nmaps, procid, spares, mapp FROM
|
|
hash_metapage_info(get_raw_page('test_hash_a_idx', 4));
|
|
|
|
SELECT magic, version, ntuples, bsize, bmsize, bmshift, maxbucket, highmask,
|
|
lowmask, ovflpoint, firstfree, nmaps, procid, spares, mapp FROM
|
|
hash_metapage_info(get_raw_page('test_hash_a_idx', 5));
|
|
|
|
SELECT live_items, dead_items, page_size, hasho_prevblkno, hasho_nextblkno,
|
|
hasho_bucket, hasho_flag, hasho_page_id FROM
|
|
hash_page_stats(get_raw_page('test_hash_a_idx', 0));
|
|
|
|
SELECT live_items, dead_items, page_size, hasho_prevblkno, hasho_nextblkno,
|
|
hasho_bucket, hasho_flag, hasho_page_id FROM
|
|
hash_page_stats(get_raw_page('test_hash_a_idx', 1));
|
|
|
|
SELECT live_items, dead_items, page_size, hasho_prevblkno, hasho_nextblkno,
|
|
hasho_bucket, hasho_flag, hasho_page_id FROM
|
|
hash_page_stats(get_raw_page('test_hash_a_idx', 2));
|
|
|
|
SELECT live_items, dead_items, page_size, hasho_prevblkno, hasho_nextblkno,
|
|
hasho_bucket, hasho_flag, hasho_page_id FROM
|
|
hash_page_stats(get_raw_page('test_hash_a_idx', 3));
|
|
|
|
SELECT live_items, dead_items, page_size, hasho_prevblkno, hasho_nextblkno,
|
|
hasho_bucket, hasho_flag, hasho_page_id FROM
|
|
hash_page_stats(get_raw_page('test_hash_a_idx', 4));
|
|
|
|
SELECT live_items, dead_items, page_size, hasho_prevblkno, hasho_nextblkno,
|
|
hasho_bucket, hasho_flag, hasho_page_id FROM
|
|
hash_page_stats(get_raw_page('test_hash_a_idx', 5));
|
|
|
|
SELECT * FROM hash_page_items(get_raw_page('test_hash_a_idx', 0));
|
|
SELECT * FROM hash_page_items(get_raw_page('test_hash_a_idx', 1));
|
|
SELECT * FROM hash_page_items(get_raw_page('test_hash_a_idx', 2));
|
|
SELECT * FROM hash_page_items(get_raw_page('test_hash_a_idx', 3));
|
|
SELECT * FROM hash_page_items(get_raw_page('test_hash_a_idx', 4));
|
|
SELECT * FROM hash_page_items(get_raw_page('test_hash_a_idx', 5));
|
|
|
|
-- Failure with non-hash index
|
|
CREATE INDEX test_hash_a_btree ON test_hash USING btree (a);
|
|
SELECT hash_bitmap_info('test_hash_a_btree', 0);
|
|
|
|
-- Failure with various modes.
|
|
-- Suppress the DETAIL message, to allow the tests to work across various
|
|
-- page sizes and architectures.
|
|
\set VERBOSITY terse
|
|
-- invalid page size
|
|
SELECT hash_metapage_info('aaa'::bytea);
|
|
SELECT hash_page_items('bbb'::bytea);
|
|
SELECT hash_page_stats('ccc'::bytea);
|
|
SELECT hash_page_type('ddd'::bytea);
|
|
-- invalid special area size
|
|
SELECT hash_metapage_info(get_raw_page('test_hash', 0));
|
|
SELECT hash_page_items(get_raw_page('test_hash', 0));
|
|
SELECT hash_page_stats(get_raw_page('test_hash', 0));
|
|
SELECT hash_page_type(get_raw_page('test_hash', 0));
|
|
\set VERBOSITY default
|
|
|
|
-- Tests with all-zero pages.
|
|
SHOW block_size \gset
|
|
SELECT hash_metapage_info(decode(repeat('00', :block_size), 'hex'));
|
|
SELECT hash_page_items(decode(repeat('00', :block_size), 'hex'));
|
|
SELECT hash_page_stats(decode(repeat('00', :block_size), 'hex'));
|
|
SELECT hash_page_type(decode(repeat('00', :block_size), 'hex'));
|
|
|
|
DROP TABLE test_hash;
|