postgresql/src/fe_utils
Tom Lane 2131c049d3 Avoid calling gettext() in signal handlers.
It seems highly unlikely that gettext() can be relied on to be
async-signal-safe.  psql used to understand that, but someone got
it wrong long ago in the src/bin/scripts/ version of handle_sigint,
and then the bad idea was perpetuated when those two versions were
unified into src/fe_utils/cancel.c.

I'm unsure why there have not been field complaints about this
... maybe gettext() is signal-safe once it's translated at least
one message?  But we have no business assuming any such thing.

In cancel.c (v13 and up), I preserved our ability to localize
"Cancel request sent" messages by invoking gettext() before
the signal handler is set up.  In earlier branches I just made
src/bin/scripts/ not localize those messages, as psql did then.

(Just for extra unsafety, the src/bin/scripts/ version was
invoking fprintf() from a signal handler.  Sigh.)

Noted while fixing signal-safety issues in PQcancel() itself.
Back-patch to all supported branches.

Discussion: https://postgr.es/m/2937814.1641960929@sss.pgh.pa.us
2022-01-17 13:30:04 -05:00
..
.gitignore Move psql's psqlscan.l into src/fe_utils. 2016-03-24 20:28:47 -04:00
Makefile Update copyright for 2022 2022-01-07 19:04:57 -05:00
archive.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
cancel.c Avoid calling gettext() in signal handlers. 2022-01-17 13:30:04 -05:00
conditional.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
connect_utils.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
mbprint.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
option_utils.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
parallel_slot.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
print.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
psqlscan.l Update copyright for 2022 2022-01-07 19:04:57 -05:00
query_utils.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
recovery_gen.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
simple_list.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
string_utils.c Update copyright for 2022 2022-01-07 19:04:57 -05:00