postgresql/src/port
Heikki Linnakangas ff30aec759 Fix and simplify check for whether we're running as Windows service.
If the process token contains SECURITY_SERVICE_RID, but it has been
disabled by the SE_GROUP_USE_FOR_DENY_ONLY attribute, win32_is_service()
would incorrectly report that we're running as a service. That situation
arises, e.g. if postmaster is launched with a restricted security token,
with the "Log in as Service" privilege explicitly removed.

Replace the broken code with CheckProcessTokenMembership(), which does
this correctly. Also replace similar code in win32_is_admin(), even
though it got this right, for simplicity and consistency.

Per bug #13755, reported by Breen Hagan. Back-patch to all supported
versions. Patch by Takayuki Tsunakawa, reviewed by Michael Paquier.

Discussion: https://www.postgresql.org/message-id/20151104062315.2745.67143%40wrigleys.postgresql.org
2017-03-17 11:14:01 +02:00
..
.gitignore Convert cvsignore to gitignore, and add .gitignore for build targets. 2010-09-22 12:57:04 +02:00
Makefile Replace PostmasterRandom() with a stronger source, second attempt. 2016-12-05 13:42:59 +02:00
README Refer to OS X as "macOS", except for the port name which is still "darwin". 2016-09-25 15:40:57 -04:00
chklocale.c Remove useless duplicate inclusions of system header files. 2017-02-25 16:12:55 -05:00
crypt.c Suppress dead, unportable src/port/crypt.c code. 2014-10-12 23:27:06 -04:00
dirent.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
dirmod.c Put back #include <windows.h> in dirmod.c. 2017-02-25 18:34:09 -05:00
erand48.c Replace PostmasterRandom() with a stronger source, second attempt. 2016-12-05 13:42:59 +02:00
fls.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
fseeko.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
getaddrinfo.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
getopt.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
getopt_long.c Add support for optional_argument to our own getopt_long() implementation. 2014-09-10 17:21:50 +02:00
getpeereid.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
getrusage.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
gettimeofday.c pgindent run for 9.5 2015-05-23 21:35:49 -04:00
inet_aton.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
inet_net_ntop.c Remove useless duplicate inclusions of system header files. 2017-02-25 16:12:55 -05:00
isinf.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
kill.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
mkdtemp.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
noblock.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
open.c Remove useless duplicate inclusions of system header files. 2017-02-25 16:12:55 -05:00
path.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
pg_crc32c_choose.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
pg_crc32c_sb8.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
pg_crc32c_sse42.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
pg_strong_random.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
pgcheckdir.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
pgmkdirp.c Fix various typos and grammar errors in comments. 2015-04-26 18:42:31 +02:00
pgsleep.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
pgstrcasecmp.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
pqsignal.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
pthread-win32.h Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
qsort.c Fix a low-probability crash in our qsort implementation. 2015-07-16 22:57:46 -04:00
qsort_arg.c Fix a low-probability crash in our qsort implementation. 2015-07-16 22:57:46 -04:00
quotes.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
random.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
rint.c Upgrade src/port/rint.c to be POSIX-compliant. 2015-03-25 15:54:18 -04:00
snprintf.c Revert error-throwing wrappers for the printf family of functions. 2015-05-19 18:19:38 -04:00
sprompt.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
srandom.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
strerror.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
strlcat.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
strlcpy.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
system.c Remove useless duplicate inclusions of system header files. 2017-02-25 16:12:55 -05:00
tar.c Allow pg_basebackup to stream transaction log in tar mode 2016-10-23 15:23:11 +02:00
thread.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
unsetenv.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
win32.ico Revert binary change in copyright year adjustment. 2012-01-01 19:40:13 -05:00
win32env.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
win32error.c Attempt to handle pending-delete files on Windows 2017-01-04 10:48:30 +01:00
win32security.c Fix and simplify check for whether we're running as Windows service. 2017-03-17 11:14:01 +02:00
win32setlocale.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
win32ver.rc Update copyright via script for 2017 2017-01-03 13:48:53 -05:00

README

src/port/README

libpgport
=========

libpgport must have special behavior.  It supplies functions to both
libraries and applications.  However, there are two complexities:

1)  Libraries need to use object files that are compiled with exactly
the same flags as the library.  libpgport might not use the same flags,
so it is necessary to recompile the object files for individual
libraries.  This is done by removing -lpgport from the link line:

        # Need to recompile any libpgport object files
        LIBS := $(filter-out -lpgport, $(LIBS))

and adding infrastructure to recompile the object files:

        OBJS= execute.o typename.o descriptor.o data.o error.o prepare.o memory.o \
                connect.o misc.o path.o exec.o \
                $(filter snprintf.o, $(LIBOBJS))

The problem is that there is no testing of which object files need to be
added, but missing functions usually show up when linking user
applications.

2) For applications, we use -lpgport before -lpq, so the static files
from libpgport are linked first.  This avoids having applications
dependent on symbols that are _used_ by libpq, but not intended to be
exported by libpq.  libpq's libpgport usage changes over time, so such a
dependency is a problem.  Windows, Linux, and macOS use an export list to
control the symbols exported by libpq.