mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-07-17 08:51:10 +02:00
d9e903f3cb
Logical decoding's reorderbuffer keeps transactions in an LSN ordered list for efficiency. To make that's efficiently possible upper-level xids are forced to be logged before nested subtransaction xids. That only works though if these records are all looked at: Unfortunately we didn't do so for e.g. row level locks, which are otherwise uninteresting for logical decoding. This could lead to errors like: "ERROR: subxact logged without previous toplevel record". It's not sufficient to just look at row locking records, the xid could appear first due to a lot of other types of records (which will trigger the transaction to be marked logged with MarkCurrentTransactionIdLoggedIfAny). So invent infrastructure to tell reorderbuffer about xids seen, when they'd otherwise not pass through reorderbuffer.c. Reported-By: Jarred Ward Bug: #13844 Discussion: 20160105033249.1087.66040@wrigleys.postgresql.org Backpatch: 9.4, where logical decoding was added
43 lines
1.2 KiB
Plaintext
43 lines
1.2 KiB
Plaintext
-- predictability
|
|
SET synchronous_commit = on;
|
|
SELECT 'init' FROM pg_create_logical_replication_slot('regression_slot', 'test_decoding');
|
|
?column?
|
|
----------
|
|
init
|
|
(1 row)
|
|
|
|
-- bug #13844, xids in non-decoded records need to be inspected
|
|
CREATE TABLE xact_test(data text);
|
|
INSERT INTO xact_test VALUES ('before-test');
|
|
BEGIN;
|
|
-- perform operation in xact that creates and logs xid, but isn't decoded
|
|
SELECT * FROM xact_test FOR UPDATE;
|
|
data
|
|
-------------
|
|
before-test
|
|
(1 row)
|
|
|
|
SAVEPOINT foo;
|
|
-- and now actually insert in subxact, xid is expected to be known
|
|
INSERT INTO xact_test VALUES ('after-assignment');
|
|
COMMIT;
|
|
-- and now show those changes
|
|
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'include-xids', '0', 'skip-empty-xacts', '1');
|
|
data
|
|
---------------------------------------------------------------
|
|
BEGIN
|
|
table public.xact_test: INSERT: data[text]:'before-test'
|
|
COMMIT
|
|
BEGIN
|
|
table public.xact_test: INSERT: data[text]:'after-assignment'
|
|
COMMIT
|
|
(6 rows)
|
|
|
|
DROP TABLE xact_test;
|
|
SELECT pg_drop_replication_slot('regression_slot');
|
|
pg_drop_replication_slot
|
|
--------------------------
|
|
|
|
(1 row)
|
|
|