1b86c81d2d
When decoding the results of a HEAP2_MULTI_INSERT (currently only generated by COPY FROM) toast columns for all but the last tuple weren't replaced by their actual contents before being handed to the output plugin. The reassembled toast datums where disregarded after every REORDER_BUFFER_CHANGE_(INSERT|UPDATE|DELETE) which is correct for plain inserts, updates, deletes, but not multi inserts - there we generate several REORDER_BUFFER_CHANGE_INSERTs for a single xl_heap_multi_insert record. To solve the problem add a clear_toast_afterwards boolean to ReorderBufferChange's union member that's used by modifications. All row changes but multi_inserts always set that to true, but multi_insert sets it only for the last change generated. Add a regression test covering decoding of multi_inserts - there was none at all before. Backpatch to 9.4 where logical decoding was introduced. Bug found by Petr Jelinek. |
||
|---|---|---|
| .. | ||
| basebackup.h | ||
| decode.h | ||
| logical.h | ||
| logicalfuncs.h | ||
| output_plugin.h | ||
| reorderbuffer.h | ||
| slot.h | ||
| snapbuild.h | ||
| syncrep.h | ||
| walreceiver.h | ||
| walsender.h | ||
| walsender_private.h | ||