mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-08-30 03:27:20 +02:00
With its current design, a careless use of pg_cryptohash_final() could would result in an out-of-bound write in memory as the size of the destination buffer to store the result digest is not known to the cryptohash internals, without the caller knowing about that. This commit adds a new argument to pg_cryptohash_final() to allow such sanity checks, and implements such defenses. The internals of SCRAM for HMAC could be tightened a bit more, but as everything is based on SCRAM_KEY_LEN with uses particular to this code there is no need to complicate its interface more than necessary, and this comes back to the refactoring of HMAC in core. Except that, this minimizes the uses of the existing DIGEST_LENGTH variables, relying instead on sizeof() for the result sizes. In ossp-uuid, this also makes the code more defensive, as it already relied on dce_uuid_t being at least the size of a MD5 digest. This is in philosophy similar tocfc40d3
for base64.c andaef8948
for hex.c. Reported-by: Ranier Vilela Author: Michael Paquier, Ranier Vilela Reviewed-by: Kyotaro Horiguchi Discussion: https://postgr.es/m/CAEudQAoqEGmcff3J4sTSV-R_16Monuz-UpJFbf_dnVH=APr02Q@mail.gmail.com
207 lines
4.4 KiB
C
207 lines
4.4 KiB
C
/*
|
|
* internal.c
|
|
* Wrapper for builtin functions
|
|
*
|
|
* Copyright (c) 2001 Marko Kreen
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
|
|
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
|
|
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
|
|
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*
|
|
* contrib/pgcrypto/internal-sha2.c
|
|
*/
|
|
|
|
#include "postgres.h"
|
|
|
|
#include <time.h>
|
|
|
|
#include "common/cryptohash.h"
|
|
#include "common/sha2.h"
|
|
#include "px.h"
|
|
|
|
void init_sha224(PX_MD *h);
|
|
void init_sha256(PX_MD *h);
|
|
void init_sha384(PX_MD *h);
|
|
void init_sha512(PX_MD *h);
|
|
|
|
/* SHA224 */
|
|
static unsigned
|
|
int_sha224_len(PX_MD *h)
|
|
{
|
|
return PG_SHA224_DIGEST_LENGTH;
|
|
}
|
|
|
|
static unsigned
|
|
int_sha224_block_len(PX_MD *h)
|
|
{
|
|
return PG_SHA224_BLOCK_LENGTH;
|
|
}
|
|
|
|
/* SHA256 */
|
|
static unsigned
|
|
int_sha256_len(PX_MD *h)
|
|
{
|
|
return PG_SHA256_DIGEST_LENGTH;
|
|
}
|
|
|
|
static unsigned
|
|
int_sha256_block_len(PX_MD *h)
|
|
{
|
|
return PG_SHA256_BLOCK_LENGTH;
|
|
}
|
|
|
|
/* SHA384 */
|
|
static unsigned
|
|
int_sha384_len(PX_MD *h)
|
|
{
|
|
return PG_SHA384_DIGEST_LENGTH;
|
|
}
|
|
|
|
static unsigned
|
|
int_sha384_block_len(PX_MD *h)
|
|
{
|
|
return PG_SHA384_BLOCK_LENGTH;
|
|
}
|
|
|
|
/* SHA512 */
|
|
static unsigned
|
|
int_sha512_len(PX_MD *h)
|
|
{
|
|
return PG_SHA512_DIGEST_LENGTH;
|
|
}
|
|
|
|
static unsigned
|
|
int_sha512_block_len(PX_MD *h)
|
|
{
|
|
return PG_SHA512_BLOCK_LENGTH;
|
|
}
|
|
|
|
/* Generic interface for all SHA2 methods */
|
|
static void
|
|
int_sha2_update(PX_MD *h, const uint8 *data, unsigned dlen)
|
|
{
|
|
pg_cryptohash_ctx *ctx = (pg_cryptohash_ctx *) h->p.ptr;
|
|
|
|
if (pg_cryptohash_update(ctx, data, dlen) < 0)
|
|
elog(ERROR, "could not update %s context", "SHA2");
|
|
}
|
|
|
|
static void
|
|
int_sha2_reset(PX_MD *h)
|
|
{
|
|
pg_cryptohash_ctx *ctx = (pg_cryptohash_ctx *) h->p.ptr;
|
|
|
|
if (pg_cryptohash_init(ctx) < 0)
|
|
elog(ERROR, "could not initialize %s context", "SHA2");
|
|
}
|
|
|
|
static void
|
|
int_sha2_finish(PX_MD *h, uint8 *dst)
|
|
{
|
|
pg_cryptohash_ctx *ctx = (pg_cryptohash_ctx *) h->p.ptr;
|
|
|
|
if (pg_cryptohash_final(ctx, dst, h->result_size(h)) < 0)
|
|
elog(ERROR, "could not finalize %s context", "SHA2");
|
|
}
|
|
|
|
static void
|
|
int_sha2_free(PX_MD *h)
|
|
{
|
|
pg_cryptohash_ctx *ctx = (pg_cryptohash_ctx *) h->p.ptr;
|
|
|
|
pg_cryptohash_free(ctx);
|
|
pfree(h);
|
|
}
|
|
|
|
/* init functions */
|
|
|
|
void
|
|
init_sha224(PX_MD *md)
|
|
{
|
|
pg_cryptohash_ctx *ctx;
|
|
|
|
ctx = pg_cryptohash_create(PG_SHA224);
|
|
md->p.ptr = ctx;
|
|
|
|
md->result_size = int_sha224_len;
|
|
md->block_size = int_sha224_block_len;
|
|
md->reset = int_sha2_reset;
|
|
md->update = int_sha2_update;
|
|
md->finish = int_sha2_finish;
|
|
md->free = int_sha2_free;
|
|
|
|
md->reset(md);
|
|
}
|
|
|
|
void
|
|
init_sha256(PX_MD *md)
|
|
{
|
|
pg_cryptohash_ctx *ctx;
|
|
|
|
ctx = pg_cryptohash_create(PG_SHA256);
|
|
md->p.ptr = ctx;
|
|
|
|
md->result_size = int_sha256_len;
|
|
md->block_size = int_sha256_block_len;
|
|
md->reset = int_sha2_reset;
|
|
md->update = int_sha2_update;
|
|
md->finish = int_sha2_finish;
|
|
md->free = int_sha2_free;
|
|
|
|
md->reset(md);
|
|
}
|
|
|
|
void
|
|
init_sha384(PX_MD *md)
|
|
{
|
|
pg_cryptohash_ctx *ctx;
|
|
|
|
ctx = pg_cryptohash_create(PG_SHA384);
|
|
md->p.ptr = ctx;
|
|
|
|
md->result_size = int_sha384_len;
|
|
md->block_size = int_sha384_block_len;
|
|
md->reset = int_sha2_reset;
|
|
md->update = int_sha2_update;
|
|
md->finish = int_sha2_finish;
|
|
md->free = int_sha2_free;
|
|
|
|
md->reset(md);
|
|
}
|
|
|
|
void
|
|
init_sha512(PX_MD *md)
|
|
{
|
|
pg_cryptohash_ctx *ctx;
|
|
|
|
ctx = pg_cryptohash_create(PG_SHA512);
|
|
md->p.ptr = ctx;
|
|
|
|
md->result_size = int_sha512_len;
|
|
md->block_size = int_sha512_block_len;
|
|
md->reset = int_sha2_reset;
|
|
md->update = int_sha2_update;
|
|
md->finish = int_sha2_finish;
|
|
md->free = int_sha2_free;
|
|
|
|
md->reset(md);
|
|
}
|