postgresql

mirror of https://git.postgresql.org/git/postgresql.git synced 2024-08-15 17:33:23 +02:00

History

Tom Lane 25b692568f Prevent dangling-pointer access when update trigger returns old tuple. A before-update row trigger may choose to return the "new" or "old" tuple unmodified. ExecBRUpdateTriggers failed to consider the second possibility, and would proceed to free the "old" tuple even if it was the one returned, leading to subsequent access to already-deallocated memory. In debug builds this reliably leads to an "invalid memory alloc request size" failure; in production builds it might accidentally work, but data corruption is also possible. This is a very old bug. There are probably a couple of reasons it hasn't been noticed up to now. It would be more usual to return NULL if one wanted to suppress the update action; returning "old" is significantly less efficient since the update will occur anyway. Also, none of the standard PLs would ever cause this because they all returned freshly-manufactured tuples even if they were just copying "old". But commit `4b93f5799` changed that for plpgsql, making it possible to see the bug with a plpgsql trigger. Still, this is certainly legal behavior for a trigger function, so it's ExecBRUpdateTriggers's fault not plpgsql's. It seems worth creating a test case that exercises returning "old" directly with a C-language trigger; testing this through plpgsql seems unreliable because its behavior might change again. Report and fix by Rushabh Lathia; regression test case by me. Back-patch to all supported branches. Discussion: https://postgr.es/m/CAGPqQf1P4pjiNPrMof=P_16E-DFjt457j+nH2ex3=nBTew7tXw@mail.gmail.com		2018-02-27 13:28:02 -05:00
..
authentication	Add installcheck support to more test suites	2018-01-23 07:11:38 -05:00
examples	Document security implications of search_path and the public schema.	2018-02-26 07:39:44 -08:00
isolation	Fix misbehavior of CTE-used-in-a-subplan during EPQ rechecks.	2018-02-19 16:00:31 -05:00
ldap	In LDAP test, restart after pg_hba.conf changes	2018-02-13 09:12:45 -05:00
locale	Add a temp-install prerequisite to "check"-like targets not having one.	2017-11-05 18:51:08 -08:00
mb	Fix MB regression tests for WAL-logging of hash indexes.	2017-03-15 07:25:36 -04:00
modules	Schema-qualify references in test_ddl_deparse test script.	2018-02-26 12:22:39 -05:00
perl	Use croak instead of die in Perl code when appropriate	2018-02-24 14:54:16 -05:00
recovery	Add installcheck support to more test suites	2018-01-23 07:11:38 -05:00
regress	Prevent dangling-pointer access when update trigger returns old tuple.	2018-02-27 13:28:02 -05:00
ssl	Check error messages in SSL tests	2018-02-24 10:07:45 -05:00
subscription	Fix filtering of unsupported relations in logical replication	2018-02-23 22:13:21 -05:00
thread	Update copyright for 2018	2018-01-02 23:30:12 -05:00
Makefile	Add LDAP authentication test suite	2017-09-15 11:44:29 -04:00
README	Add TAP tests for password-based authentication methods.	2017-03-17 11:34:16 +02:00

README

PostgreSQL tests
================

This directory contains a variety of test infrastructure as well as some of the
tests in PostgreSQL. Not all tests are here -- in particular, there are more in
individual contrib/ modules and in src/bin.

Not all these tests get run by "make check". Check src/test/Makefile to see
which tests get run automatically.

authentication/
  Tests for authentication

examples/
  Demonstration programs for libpq that double as regression tests via
  "make check"

isolation/
  Tests for concurrent behavior at the SQL level

locale/
  Sanity checks for locale data, encodings, etc

mb/
  Tests for multibyte encoding (UTF-8) support

modules/
  Extensions used only or mainly for test purposes, generally not suitable
  for installing in production databases

perl/
  Infrastructure for Perl-based TAP tests

recovery/
  Test suite for recovery and replication

regress/
  PostgreSQL's main regression test suite, pg_regress

ssl/
  Tests to exercise and verify SSL certificate handling

subscription/
  Tests for logical replication

thread/
  A thread-safety-testing utility used by configure