mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-08-02 16:33:24 +02:00
09d8d110a6
Replace some bogus "x[1]" declarations with "x[FLEXIBLE_ARRAY_MEMBER]". Aside from being more self-documenting, this should help prevent bogus warnings from static code analyzers and perhaps compiler misoptimizations. This patch is just a down payment on eliminating the whole problem, but it gets rid of a lot of easy-to-fix cases. Note that the main problem with doing this is that one must no longer rely on computing sizeof(the containing struct), since the result would be compiler-dependent. Instead use offsetof(struct, lastfield). Autoconf also warns against spelling that offsetof(struct, lastfield[0]). Michael Paquier, review and additional fixes by me.
49 lines
1.5 KiB
C
49 lines
1.5 KiB
C
/* contrib/cube/cubedata.h */
|
|
|
|
#define CUBE_MAX_DIM (100)
|
|
|
|
typedef struct NDBOX
|
|
{
|
|
/* varlena header (do not touch directly!) */
|
|
int32 vl_len_;
|
|
|
|
/*----------
|
|
* Header contains info about NDBOX. For binary compatibility with old
|
|
* versions, it is defined as "unsigned int".
|
|
*
|
|
* Following information is stored:
|
|
*
|
|
* bits 0-7 : number of cube dimensions;
|
|
* bits 8-30 : unused, initialize to zero;
|
|
* bit 31 : point flag. If set, the upper right coordinates are not
|
|
* stored, and are implicitly the same as the lower left
|
|
* coordinates.
|
|
*----------
|
|
*/
|
|
unsigned int header;
|
|
|
|
/*
|
|
* The lower left coordinates for each dimension come first, followed by
|
|
* upper right coordinates unless the point flag is set.
|
|
*/
|
|
double x[FLEXIBLE_ARRAY_MEMBER];
|
|
} NDBOX;
|
|
|
|
#define POINT_BIT 0x80000000
|
|
#define DIM_MASK 0x7fffffff
|
|
|
|
#define IS_POINT(cube) ( ((cube)->header & POINT_BIT) != 0 )
|
|
#define SET_POINT_BIT(cube) ( (cube)->header |= POINT_BIT )
|
|
#define DIM(cube) ( (cube)->header & DIM_MASK )
|
|
#define SET_DIM(cube, _dim) ( (cube)->header = ((cube)->header & ~DIM_MASK) | (_dim) )
|
|
|
|
#define LL_COORD(cube, i) ( (cube)->x[i] )
|
|
#define UR_COORD(cube, i) ( IS_POINT(cube) ? (cube)->x[i] : (cube)->x[(i) + DIM(cube)] )
|
|
|
|
#define POINT_SIZE(_dim) (offsetof(NDBOX, x) + sizeof(double)*(_dim))
|
|
#define CUBE_SIZE(_dim) (offsetof(NDBOX, x) + sizeof(double)*(_dim)*2)
|
|
|
|
#define DatumGetNDBOX(x) ((NDBOX *) PG_DETOAST_DATUM(x))
|
|
#define PG_GETARG_NDBOX(x) DatumGetNDBOX(PG_GETARG_DATUM(x))
|
|
#define PG_RETURN_NDBOX(x) PG_RETURN_POINTER(x)
|