postgresql/src
Michael Paquier 384f1abdb9 Fix portability issues in new TAP tests of psql
The tests added by c0280bc and d9ddc50 in 001_basic.pl have introduced
commands calling directly psql, making them sensitive to the
environment.  One issue was that those commands forgot -X to not use a
local .psqlrc, causing all those tests to fail if psql cannot properly
parse this file.

TAP tests should be designed so as they run in an isolated fashion,
without any dependency on the environment where they are run.  As
PostgresNode::psql gives already all the facilities those new tests
need, switch to that instead of calling plain psql commands where
interactions with a backend are needed.  The test is slightly refactored
to be able to check after the expected patterns of stdout and stderr,
keeping the same amount of coverage as previously.

Reported-by: Peter Geoghegan
Discussion: https://postgr.es/m/CAH2-Wzn8ftvcDPwomn+y04JJzbT=TG7TN=QsmSEATUOW-ZuvQQ@mail.gmail.com
2021-10-18 09:51:21 +09:00
..
backend Remove obsolete nbtree deduplication comments. 2021-10-15 15:25:20 -07:00
bin Fix portability issues in new TAP tests of psql 2021-10-18 09:51:21 +09:00
common Fix memory leak in pg_hmac 2021-10-01 22:47:05 +02:00
fe_utils Skip trailing whitespaces when parsing integer options 2021-07-27 10:39:05 +09:00
include shm_mq: Update mq_bytes_written less often. 2021-10-14 16:13:36 -04:00
interfaces Fix check for trapping exit() calls in libpq 2021-10-04 21:04:11 +02:00
makefiles Add NO_INSTALL option to pgxs 2021-05-27 13:58:29 +02:00
pl plperl: update ppport.h to Perl 5.34.0. 2021-10-07 13:59:43 -04:00
port Treat ETIMEDOUT as indicating a non-recoverable connection failure. 2021-09-30 14:16:08 -04:00
template
test Fix PostgresNode install_path sanity tests that fail on Windows 2021-10-15 12:56:29 -04:00
timezone Doc: improve timezone/README's recipe for tracking Windows zones. 2021-10-06 13:38:42 -04:00
tools Fix WAL replay in presence of an incomplete record 2021-09-29 11:21:51 -03:00
tutorial
.gitignore
DEVELOPERS
Makefile
Makefile.global.in Provide error hint if TAP tests are not enabled 2021-10-04 11:46:29 +02:00
Makefile.shlib AIX: Fix missing libpq symbols by respecting SHLIB_EXPORTS. 2021-09-06 11:27:59 -07:00
nls-global.mk