Michael Paquier 8a22a40b2c Remove assertion for ALTER TABLE .. DETACH PARTITION CONCURRENTLY ... One code path related to this flavor of ALTER TABLE was checking that the relation to detach has to be a normal table or a partitioned table, which would fail if using the command with a different relation kind. Views, sequences and materialized views cannot be part of a partition tree, so these would cause the command to fail anyway, but the assertion was triggered. Foreign tables can be part of a partition tree, and again the assertion would have failed. The simplest solution is just to remove this assertion, so as we get the same failure as the non-concurrent code path. While on it, add a regression test in postgres_fdw for the concurrent partition detach of a foreign table, as per a suggestion from Alexander Lakhin. Issue introduced in 71f4c8c. Reported-by: Alexander Lakhin Author: Michael Paquier, Alexander Lakhin Reviewed-by: Peter Eisentraut, Kyotaro Horiguchi Discussion: https://postgr.es/m/17339-a9e09aaf38a3457a@postgresql.org Backpatch-through: 14		2021-12-22 15:38:05 +09:00
..
expected	Remove assertion for ALTER TABLE .. DETACH PARTITION CONCURRENTLY	2021-12-22 15:38:05 +09:00
sql	Remove assertion for ALTER TABLE .. DETACH PARTITION CONCURRENTLY	2021-12-22 15:38:05 +09:00
.gitignore
connection.c	postgres_fdw: Fix unexpected reporting of empty message.	2021-12-03 17:37:08 +09:00
deparse.c
Makefile
option.c
postgres_fdw--1.0--1.1.sql
postgres_fdw--1.0.sql
postgres_fdw.c	Fix null-pointer crash in postgres_fdw's conversion_error_callback.	2021-10-06 15:50:24 -04:00
postgres_fdw.control
postgres_fdw.h
shippable.c