postgresql

History

Tom Lane 3c84046490 Fix assorted bugs in CREATE/DROP INDEX CONCURRENTLY. Commit `8cb53654db`, which introduced DROP INDEX CONCURRENTLY, managed to break CREATE INDEX CONCURRENTLY via a poor choice of catalog state representation. The pg_index state for an index that's reached the final pre-drop stage was the same as the state for an index just created by CREATE INDEX CONCURRENTLY. This meant that the (necessary) change to make RelationGetIndexList ignore about-to-die indexes also made it ignore freshly-created indexes; which is catastrophic because the latter do need to be considered in HOT-safety decisions. Failure to do so leads to incorrect index entries and subsequently wrong results from queries depending on the concurrently-created index. To fix, add an additional boolean column "indislive" to pg_index, so that the freshly-created and about-to-die states can be distinguished. (This change obviously is only possible in HEAD. This patch will need to be back-patched, but in 9.2 we'll use a kluge consisting of overloading the formerly-impossible state of indisvalid = true and indisready = false.) In addition, change CREATE/DROP INDEX CONCURRENTLY so that the pg_index flag changes they make without exclusive lock on the index are made via heap_inplace_update() rather than a normal transactional update. The latter is not very safe because moving the pg_index tuple could result in concurrent SnapshotNow scans finding it twice or not at all, thus possibly resulting in index corruption. This is a pre-existing bug in CREATE INDEX CONCURRENTLY, which was copied into the DROP code. In addition, fix various places in the code that ought to check to make sure that the indexes they are manipulating are valid and/or ready as appropriate. These represent bugs that have existed since 8.2, since a failed CREATE INDEX CONCURRENTLY could leave a corrupt or invalid index behind, and we ought not try to do anything that might fail with such an index. Also fix RelationReloadIndexInfo to ensure it copies all the pg_index columns that are allowed to change after initial creation. Previously we could have been left with stale values of some fields in an index relcache entry. It's not clear whether this actually had any user-visible consequences, but it's at least a bug waiting to happen. In addition, do some code and docs review for DROP INDEX CONCURRENTLY; some cosmetic code cleanup but mostly addition and revision of comments. This will need to be back-patched, but in a noticeably different form, so I'm committing it to HEAD before working on the back-patch. Problem reported by Amit Kapila, diagnosis by Pavan Deolassee, fix by Tom Lane and Andres Freund.		2012-11-28 21:26:01 -05:00
..
adminpack	Update copyright notices for year 2012.	2012-01-01 18:01:58 -05:00
auth_delay	Limit values of archive_timeout, post_auth_delay, auth_delay.milliseconds.	2012-11-18 17:15:06 -05:00
auto_explain	Fix assorted compilation failures in contrib	2012-08-28 23:50:49 -04:00
btree_gin	Throw a useful error message if an extension script file is fed to psql.	2011-10-12 15:45:03 -04:00
btree_gist	Reduce messages about implicit indexes and sequences to DEBUG1.	2012-07-04 20:35:29 -04:00
chkpass	Throw a useful error message if an extension script file is fed to psql.	2011-10-12 15:45:03 -04:00
citext	Reduce messages about implicit indexes and sequences to DEBUG1.	2012-07-04 20:35:29 -04:00
cube	Refactor flex and bison make rules	2012-10-11 06:57:04 -04:00
dblink	Remove configure-option-dependent test cases from dblink tests.	2012-10-10 20:14:26 -04:00
dict_int	Update copyright notices for year 2012.	2012-01-01 18:01:58 -05:00
dict_xsyn	Update copyright notices for year 2012.	2012-01-01 18:01:58 -05:00
dummy_seclabel	Update copyright notices for year 2012.	2012-01-01 18:01:58 -05:00
earthdistance	Throw a useful error message if an extension script file is fed to psql.	2011-10-12 15:45:03 -04:00
file_fdw	Oops, have to rename local variables called 'errcontext' in contrib, too.	2012-11-12 18:30:51 +02:00
fuzzystrmatch	Even more duplicate word removal, in the spirit of the season	2012-05-02 20:56:03 +03:00
hstore	Provide some static-assertion functionality on all compilers.	2012-09-30 22:46:29 -04:00
intagg	Throw a useful error message if an extension script file is fed to psql.	2011-10-12 15:45:03 -04:00
intarray	Remove unreachable code	2012-07-16 22:15:03 +03:00
isn	Update copyright notices for year 2012.	2012-01-01 18:01:58 -05:00
lo	Throw a useful error message if an extension script file is fed to psql.	2011-10-12 15:45:03 -04:00
ltree	Split tuple struct defs from htup.h to htup_details.h	2012-08-30 16:52:35 -04:00
oid2name	Work around unportable behavior of malloc(0) and realloc(NULL, 0).	2012-10-02 17:32:42 -04:00
pageinspect	Split tuple struct defs from htup.h to htup_details.h	2012-08-30 16:52:35 -04:00
passwordcheck	Update copyright notices for year 2012.	2012-01-01 18:01:58 -05:00
pg_archivecleanup	In our source code, make a copy of getopt's 'optarg' string arguments,	2012-10-12 13:35:43 -04:00
pg_buffercache	Split tuple struct defs from htup.h to htup_details.h	2012-08-30 16:52:35 -04:00
pg_freespacemap	Throw a useful error message if an extension script file is fed to psql.	2011-10-12 15:45:03 -04:00
pg_standby	In our source code, make a copy of getopt's 'optarg' string arguments,	2012-10-12 13:35:43 -04:00
pg_stat_statements	Remove pg_stat_statements--1.0.sql, too.	2012-08-28 14:33:56 -04:00
pg_test_fsync	Fix unportable format string.	2012-10-12 13:22:11 -04:00
pg_test_timing	Adjust pg_test_timing to show shortest test durations first, place	2012-08-28 12:57:13 -04:00
pg_trgm	Fix bugs in contrib/pg_trgm's LIKE pattern analysis code.	2012-08-20 13:25:42 -04:00
pg_upgrade	In pg_upgrade, simplify function copy_file() by using pg_malloc() and	2012-11-24 22:39:03 -05:00
pg_upgrade_support	Update copyright notices for year 2012.	2012-01-01 18:01:58 -05:00
pgbench	Prevent overflow in pgbench's percent-done display.	2012-10-20 12:44:18 -04:00
pgcrypto	Run pgindent on 9.2 source tree in preparation for first 9.3	2012-06-10 15:20:04 -04:00
pgrowlocks	Throw a useful error message if an extension script file is fed to psql.	2011-10-12 15:45:03 -04:00
pgstattuple	Reduce messages about implicit indexes and sequences to DEBUG1.	2012-07-04 20:35:29 -04:00
seg	Refactor flex and bison make rules	2012-10-11 06:57:04 -04:00
sepgsql	Add context info to OAT_POST_CREATE security hook	2012-10-23 18:24:24 -03:00
spi	Run pgindent on 9.2 source tree in preparation for first 9.3	2012-06-10 15:20:04 -04:00
sslinfo	Lots of doc corrections.	2012-04-23 22:43:09 -04:00
start-scripts	Support Linux's oom_score_adj API as well as the older oom_adj API.	2012-06-13 15:35:52 -04:00
tablefunc	Split tuple struct defs from htup.h to htup_details.h	2012-08-30 16:52:35 -04:00
tcn	Fix assorted bugs in CREATE/DROP INDEX CONCURRENTLY.	2012-11-28 21:26:01 -05:00
test_parser	Fix one-byte buffer overrun in contrib/test_parser.	2012-01-09 19:56:27 -05:00
tsearch2	Update copyright notices for year 2012.	2012-01-01 18:01:58 -05:00
unaccent	Fix some typos	2012-04-22 19:23:47 +03:00
uuid-ossp	Update copyright notices for year 2012.	2012-01-01 18:01:58 -05:00
vacuumlo	Make oid2name, pgbench, and vacuumlo set fallback_application_name.	2012-07-04 15:39:33 -04:00
xml2	Split tuple struct defs from htup.h to htup_details.h	2012-08-30 16:52:35 -04:00
Makefile	pg_test_timing utility, to measure clock monotonicity and timing cost.	2012-03-27 16:14:00 -04:00
README	Update contrib/README	2012-04-14 09:29:54 +03:00
contrib-global.mk	Remove cvs keywords from all files.	2010-09-20 22:08:53 +02:00

README

The PostgreSQL contrib tree
---------------------------

This subtree contains porting tools, analysis utilities, and plug-in
features that are not part of the core PostgreSQL system, mainly
because they address a limited audience or are too experimental to be
part of the main source tree.  This does not preclude their
usefulness.

User documentation for each module appears in the main SGML
documentation.

When building from the source distribution, these modules are not
built automatically, unless you build the "world" target.  You can
also build and install them all by running "gmake all" and "gmake
install" in this directory; or to build and install just one selected
module, do the same in that module's subdirectory.

Some directories supply new user-defined functions, operators, or
types.  To make use of one of these modules, after you have installed
the code you need to register the new SQL objects in the database
system by executing a CREATE EXTENSION command.  In a fresh database,
you can simply do

    CREATE EXTENSION module_name;

See the PostgreSQL documentation for more information about this
procedure.