mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-07-14 08:09:16 +02:00
a443c1b2d6
For no obvious reason, isolationtester has always insisted that
session and step names be written with double quotes. This is
fairly tedious and does little for test readability, especially
since the names that people actually choose almost always look
like normal identifiers. Hence, let's tweak the lexer to allow
SQL-like identifiers not only double-quoted strings.
(They're SQL-like, not exactly SQL, because I didn't add any
case-folding logic. Also there's no provision for U&"..." names,
not that anyone's likely to care.)
There is one incompatibility introduced by this change: if you write
"foo""bar" with no space, that used to be taken as two identifiers,
but now it's just one identifier with an embedded quote mark.
I converted all the src/test/isolation/ specfiles to remove
unnecessary double quotes, but stopped there because my
eyes were glazing over already.
Like 741d7f104, back-patch to all supported branches, so that this
isn't a stumbling block for back-patching isolation test changes.
Discussion: https://postgr.es/m/759113.1623861959@sss.pgh.pa.us
43 lines
1.8 KiB
Ruby
43 lines
1.8 KiB
Ruby
# Test advancement of the slot's oldest xmin
|
|
|
|
setup
|
|
{
|
|
SELECT 'init' FROM pg_create_logical_replication_slot('isolation_slot', 'test_decoding'); -- must be first write in xact
|
|
DROP TYPE IF EXISTS basket;
|
|
CREATE TYPE basket AS (apples integer, pears integer, mangos integer);
|
|
DROP TABLE IF EXISTS harvest;
|
|
CREATE TABLE harvest(fruits basket);
|
|
}
|
|
|
|
teardown
|
|
{
|
|
DROP TABLE IF EXISTS harvest;
|
|
DROP TYPE IF EXISTS basket;
|
|
SELECT 'stop' FROM pg_drop_replication_slot('isolation_slot');
|
|
}
|
|
|
|
session "s0"
|
|
setup { SET synchronous_commit=on; }
|
|
step "s0_begin" { BEGIN; }
|
|
step "s0_getxid" { SELECT pg_current_xact_id() IS NULL; }
|
|
step "s0_alter" { ALTER TYPE basket DROP ATTRIBUTE mangos; }
|
|
step "s0_commit" { COMMIT; }
|
|
step "s0_checkpoint" { CHECKPOINT; }
|
|
step "s0_vacuum" { VACUUM pg_attribute; }
|
|
step "s0_get_changes" { SELECT data FROM pg_logical_slot_get_changes('isolation_slot', NULL, NULL, 'include-xids', '0', 'skip-empty-xacts', '1'); }
|
|
|
|
session "s1"
|
|
setup { SET synchronous_commit=on; }
|
|
step "s1_begin" { BEGIN; }
|
|
step "s1_insert" { INSERT INTO harvest VALUES ((1, 2, 3)); }
|
|
step "s1_commit" { COMMIT; }
|
|
|
|
# Checkpoint with following get_changes forces xmin advancement. We do
|
|
# get_changes twice because if one more xl_running_xacts record had slipped
|
|
# before our CHECKPOINT, xmin will be advanced only on this record, thus not
|
|
# reaching value needed for vacuuming corresponding pg_attribute entry. ALTER of
|
|
# composite type is a rare form of DDL which allows T1 to see the tuple which
|
|
# will be removed (xmax set) before T1 commits. That is, interlocking doesn't
|
|
# forbid modifying catalog after someone read it (and didn't commit yet).
|
|
permutation "s0_begin" "s0_getxid" "s1_begin" "s1_insert" "s0_alter" "s0_commit" "s0_checkpoint" "s0_get_changes" "s0_get_changes" "s1_commit" "s0_vacuum" "s0_get_changes"
|