mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-08-22 11:13:23 +02:00
4240e429d0
In the previous coding, we would look up a relation in RangeVarGetRelid, lock the resulting OID, and then AcceptInvalidationMessages(). While this was sufficient to ensure that we noticed any changes to the relation definition before building the relcache entry, it didn't handle the possibility that the name we looked up no longer referenced the same OID. This was particularly problematic in the case where a table had been dropped and recreated: we'd latch on to the entry for the old relation and fail later on. Now, we acquire the relation lock inside RangeVarGetRelid, and retry the name lookup if we notice that invalidation messages have been processed meanwhile. Many operations that would previously have failed with an error in the presence of concurrent DDL will now succeed. There is a good deal of work remaining to be done here: many callers of RangeVarGetRelid still pass NoLock for one reason or another. In addition, nothing in this patch guards against the possibility that the meaning of an unqualified name might change due to the creation of a relation in a schema earlier in the user's search path than the one where it was previously found. Furthermore, there's nothing at all here to guard against similar race conditions for non-relations. For all that, it's a start. Noah Misch and Robert Haas |
||
|---|---|---|
| .. | ||
| aggregatecmds.c | ||
| alter.c | ||
| analyze.c | ||
| async.c | ||
| cluster.c | ||
| collationcmds.c | ||
| comment.c | ||
| constraint.c | ||
| conversioncmds.c | ||
| copy.c | ||
| dbcommands.c | ||
| define.c | ||
| discard.c | ||
| explain.c | ||
| extension.c | ||
| foreigncmds.c | ||
| functioncmds.c | ||
| indexcmds.c | ||
| lockcmds.c | ||
| Makefile | ||
| opclasscmds.c | ||
| operatorcmds.c | ||
| portalcmds.c | ||
| prepare.c | ||
| proclang.c | ||
| schemacmds.c | ||
| seclabel.c | ||
| sequence.c | ||
| tablecmds.c | ||
| tablespace.c | ||
| trigger.c | ||
| tsearchcmds.c | ||
| typecmds.c | ||
| user.c | ||
| vacuum.c | ||
| vacuumlazy.c | ||
| variable.c | ||
| view.c | ||