mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-09-08 18:49:21 +02:00
4247db6252
PQnotifies() is defined to just process already-read data, not try to read any more from the socket. (This is a debatable decision, perhaps, but I'm hesitant to change longstanding library behavior.) The documentation has long recommended calling PQconsumeInput() before PQnotifies() to ensure that any already-arrived message would get absorbed and processed. However, psql did not get that memo, which explains why it's not very reliable about reporting notifications promptly. Also, most (not quite all) callers called PQconsumeInput() just once before a PQnotifies() loop. Taking this recommendation seriously implies that we should do PQconsumeInput() before each call. This is more important now that we have "payload" strings in notification messages than it was before; that increases the probability of having more than one packet's worth of notify messages. Hence, adjust code as well as documentation examples to do it like that. Back-patch to 9.5 to match related server fixes. In principle we could probably go back further with these changes, but given lack of field complaints I doubt it's worthwhile. Discussion: https://postgr.es/m/CAOYf6ec-TmRYjKBXLLaGaB-jrd=mjG1Hzn1a1wufUAR39PQYhw@mail.gmail.com |
||
|---|---|---|
| .. | ||
| po | ||
| .gitignore | ||
| command.c | ||
| command.h | ||
| common.c | ||
| common.h | ||
| copy.c | ||
| copy.h | ||
| create_help.pl | ||
| crosstabview.c | ||
| crosstabview.h | ||
| describe.c | ||
| describe.h | ||
| help.c | ||
| help.h | ||
| input.c | ||
| input.h | ||
| large_obj.c | ||
| large_obj.h | ||
| mainloop.c | ||
| mainloop.h | ||
| Makefile | ||
| nls.mk | ||
| prompt.c | ||
| prompt.h | ||
| psqlrc.sample | ||
| psqlscanslash.h | ||
| psqlscanslash.l | ||
| settings.h | ||
| startup.c | ||
| stringutils.c | ||
| stringutils.h | ||
| tab-complete.c | ||
| tab-complete.h | ||
| variables.c | ||
| variables.h | ||