598e0114a3
This commit fixes a few things: * Instead of checking for CPU support of the "xsave" extension, we need to check for OS support of XGETBV instructions via the "osxsave" flag. * We must check that additional XCR0 bits are set to be sure the ZMM registers are fully enabled. * We should use the recommended ordering of steps. Specifically, we need to check that the ZMM registers are enabled prior to checking for AVX-512 via CPUID. In passing, split this code into separate functions to improve readability. Reported-by: Andrew Kane Reviewed-by: Akash Shankaran, Raghuveer Devulapalli Discussion: https://postgr.es/m/20240418024459.GA3385227%40nathanxps13 |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| Makefile | ||
| README | ||
| bsearch_arg.c | ||
| chklocale.c | ||
| dirent.c | ||
| dirmod.c | ||
| explicit_bzero.c | ||
| getopt.c | ||
| getopt_long.c | ||
| getpeereid.c | ||
| inet_aton.c | ||
| inet_net_ntop.c | ||
| kill.c | ||
| meson.build | ||
| mkdtemp.c | ||
| noblock.c | ||
| open.c | ||
| path.c | ||
| pg_bitutils.c | ||
| pg_crc32c_armv8.c | ||
| pg_crc32c_armv8_choose.c | ||
| pg_crc32c_loongarch.c | ||
| pg_crc32c_sb8.c | ||
| pg_crc32c_sse42.c | ||
| pg_crc32c_sse42_choose.c | ||
| pg_popcount_avx512.c | ||
| pg_popcount_avx512_choose.c | ||
| pg_strong_random.c | ||
| pgcheckdir.c | ||
| pgmkdirp.c | ||
| pgsleep.c | ||
| pgstrcasecmp.c | ||
| pgstrsignal.c | ||
| pqsignal.c | ||
| pthread-win32.h | ||
| pthread_barrier_wait.c | ||
| qsort.c | ||
| qsort_arg.c | ||
| quotes.c | ||
| snprintf.c | ||
| strerror.c | ||
| strlcat.c | ||
| strlcpy.c | ||
| strnlen.c | ||
| strtof.c | ||
| system.c | ||
| tar.c | ||
| user.c | ||
| win32.ico | ||
| win32common.c | ||
| win32dlopen.c | ||
| win32env.c | ||
| win32error.c | ||
| win32fdatasync.c | ||
| win32fseek.c | ||
| win32gai_strerror.c | ||
| win32getrusage.c | ||
| win32gettimeofday.c | ||
| win32link.c | ||
| win32ntdll.c | ||
| win32pread.c | ||
| win32pwrite.c | ||
| win32security.c | ||
| win32setlocale.c | ||
| win32stat.c | ||
| win32ver.rc | ||
README
src/port/README
libpgport
=========
libpgport must have special behavior. It supplies functions to both
libraries and applications. However, there are two complexities:
1) Libraries need to use object files that are compiled with exactly
the same flags as the library. libpgport might not use the same flags,
so it is necessary to recompile the object files for individual
libraries. This is done by removing -lpgport from the link line:
# Need to recompile any libpgport object files
LIBS := $(filter-out -lpgport, $(LIBS))
and adding infrastructure to recompile the object files:
OBJS= execute.o typename.o descriptor.o data.o error.o prepare.o memory.o \
connect.o misc.o path.o exec.o \
$(filter strlcat.o, $(LIBOBJS))
The problem is that there is no testing of which object files need to be
added, but missing functions usually show up when linking user
applications.
2) For applications, we use -lpgport before -lpq, so the static files
from libpgport are linked first. This avoids having applications
dependent on symbols that are _used_ by libpq, but not intended to be
exported by libpq. libpq's libpgport usage changes over time, so such a
dependency is a problem. Windows, Linux, and macOS use an export
list to control the symbols exported by libpq.