postgresql/src/include
Tom Lane 49a08ca1e9 Adjust the permissions required for COMMENT ON ROLE.
Formerly, any member of a role could change the role's comment, as of
course could superusers; but holders of CREATEROLE privilege could not,
unless they were also members.  This led to the odd situation that a
CREATEROLE holder could create a role but then could not comment on it.
It also seems a bit dubious to let an unprivileged user change his own
comment, let alone those of group roles he belongs to.  So, change the
rule to be "you must be superuser to comment on a superuser role, or
hold CREATEROLE to comment on non-superuser roles".  This is the same
as the privilege check for creating/dropping roles, and thus fits much
better with the rule for other object types, namely that only the owner
of an object can comment on it.

In passing, clean up the documentation for COMMENT a little bit.

Per complaint from Owen Jacobson and subsequent discussion.
2011-03-09 11:28:34 -05:00
..
access Hot Standby feedback for avoidance of cleanup conflicts on standby. 2011-02-16 19:29:37 +00:00
bootstrap Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
catalog Catversion increment for pg_stat_replication changes for syncrep 2011-03-06 23:44:44 +00:00
commands Fix dangling-pointer problem in before-row update trigger processing. 2011-02-21 21:19:50 -05:00
executor Refactor the executor's API to support data-modifying CTEs better. 2011-02-27 13:44:12 -05:00
foreign Implement an API to let foreign-data wrappers actually be functional. 2011-02-20 00:18:14 -05:00
lib Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
libpq Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
mb Add ENCODING option to COPY TO/FROM and file_fdw. 2011-02-21 14:32:40 +09:00
nodes Allow non-superusers to create (some) extensions. 2011-03-04 16:08:53 -05:00
optimizer Support data-modifying commands (INSERT/UPDATE/DELETE) in WITH. 2011-02-25 18:58:02 -05:00
parser Support data-modifying commands (INSERT/UPDATE/DELETE) in WITH. 2011-02-25 18:58:02 -05:00
port Fix typo 2011-01-30 20:34:05 -05:00
portability Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
postmaster Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
regex Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
replication Add new files for syncrep missed in previous commit 2011-03-06 23:39:14 +00:00
rewrite Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
snowball Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
storage Truncate predicate lock manager's SLRU lazily at checkpoint. That's safer 2011-03-08 12:12:54 +02:00
tcop Rearrange snapshot handling to make rule expansion more consistent. 2011-02-28 23:28:06 -05:00
tsearch Add backwards-compatible declarations of some core GIN support functions. 2011-02-16 17:24:46 -05:00
utils Adjust the permissions required for COMMENT ON ROLE. 2011-03-09 11:28:34 -05:00
.gitignore Convert cvsignore to gitignore, and add .gitignore for build targets. 2010-09-22 12:57:04 +02:00
c.h Enable building with the Mingw64 compiler. 2011-01-30 19:56:46 -05:00
fmgr.h Implement an API to let foreign-data wrappers actually be functional. 2011-02-20 00:18:14 -05:00
funcapi.h Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
getaddrinfo.h Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
getopt_long.h Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
Makefile Make handling of errcodes.h more consistent with other generated headers. 2011-02-04 09:29:10 -05:00
miscadmin.h Code review for postmaster.pid contents changes. 2011-01-13 19:01:28 -05:00
pg_config_manual.h Support unlogged tables. 2010-12-29 06:48:53 -05:00
pg_config.h.in Per-column collation support 2011-02-08 23:04:18 +02:00
pg_config.h.win32 Only build in crashdump support on Windows if there's a working dbghelp.h. 2010-12-26 10:34:47 -05:00
pg_trace.h Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
pgstat.h Add client_hostname field to pg_stat_activity. 2011-02-17 16:03:28 -05:00
pgtime.h Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
port.h Properly handle Win32 paths of 'E:abc', which can be either absolute or 2011-02-12 09:47:51 -05:00
postgres_ext.h Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
postgres_fe.h Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
postgres.h Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
rusagestub.h Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
windowapi.h Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00