postgresql/contrib/pageinspect
Michael Paquier 9d41ecfcd9 pageinspect: Fix crash with gist_page_items()
Attempting to use this function with a raw page not coming from a GiST
index would cause a crash, as it was missing the same sanity checks as
gist_page_items_bytea().  This slightly refactors the code so as all the
basic validation checks for GiST pages are done in a single routine,
in the same fashion as the pageinspect functions for hash and BRIN.

This fixes an issue similar to 076f4d9.  A test is added to stress for
this case.  While on it, I have added a similar test for
brin_page_items() with a combination make of a valid GiST index and a
raw btree page.  This one was already protected, but it was not tested.

Reported-by: Egor Chindyaskin
Author: Dmitry Koval
Discussion: https://postgr.es/m/17815-fc4a2d3b74705703@postgresql.org
Backpatch-through: 14
2023-03-02 14:03:08 +09:00
..
expected pageinspect: Fix crash with gist_page_items() 2023-03-02 14:03:08 +09:00
sql pageinspect: Fix crash with gist_page_items() 2023-03-02 14:03:08 +09:00
.gitignore pageinspect: Add tests 2016-11-01 14:02:16 -04:00
Makefile Mark pageinspect's disk-accessing functions as parallel restricted. 2022-11-21 15:37:10 -05:00
brinfuncs.c Rename SetSingleFuncCall() to InitMaterializedSRF() 2022-10-18 10:22:40 +09:00
btreefuncs.c pageinspect: Fix handling of all-zero pages 2022-04-14 15:08:03 +09:00
fsmfuncs.c pageinspect: Fix handling of all-zero pages 2022-04-14 15:08:03 +09:00
ginfuncs.c pageinspect: Fix handling of all-zero pages 2022-04-14 15:08:03 +09:00
gistfuncs.c pageinspect: Fix crash with gist_page_items() 2023-03-02 14:03:08 +09:00
hashfuncs.c Add macros in hash and btree AMs to get the special area of their pages 2022-04-01 13:24:50 +09:00
heapfuncs.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
pageinspect--1.0--1.1.sql Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:37 +02:00
pageinspect--1.1--1.2.sql Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:37 +02:00
pageinspect--1.2--1.3.sql pageinspect/BRIN: minor tweaks 2014-12-02 12:20:50 -03:00
pageinspect--1.3--1.4.sql Add forgotten file in commit d6061f83a1 2015-11-25 16:59:07 +03:00
pageinspect--1.4--1.5.sql Update pageinspect extension for parallel query. 2016-06-09 17:18:09 -04:00
pageinspect--1.5--1.6.sql pageinspect: Add bt_page_items function with bytea argument 2017-04-04 23:52:55 -04:00
pageinspect--1.5.sql Update pageinspect extension for parallel query. 2016-06-09 17:18:09 -04:00
pageinspect--1.6--1.7.sql Skip full index scan during cleanup of B-tree indexes when possible 2018-04-04 19:29:00 +03:00
pageinspect--1.7--1.8.sql pageinspect: Fix types used for bt_metap() columns. 2020-03-07 16:44:53 -08:00
pageinspect--1.8--1.9.sql Use full 64-bit XIDs in deleted nbtree pages. 2021-02-24 18:41:34 -08:00
pageinspect--1.9--1.10.sql pageinspect: Improve page_header() for pages of 32kB 2021-07-12 11:05:27 +09:00
pageinspect--1.10--1.11.sql Mark pageinspect's disk-accessing functions as parallel restricted. 2022-11-21 15:37:10 -05:00
pageinspect.control Mark pageinspect's disk-accessing functions as parallel restricted. 2022-11-21 15:37:10 -05:00
pageinspect.h Update copyright for 2022 2022-01-07 19:04:57 -05:00
rawpage.c pageinspect: Fix handling of all-zero pages 2022-04-14 15:08:03 +09:00