postgresql/contrib/pgcrypto
Noah Misch 85270ac7a2 pgcrypto: Report errant decryption as "Wrong key or corrupt data".
This has been the predominant outcome.  When the output of decrypting
with a wrong key coincidentally resembled an OpenPGP packet header,
pgcrypto could instead report "Corrupt data", "Not text data" or
"Unsupported compression algorithm".  The distinct "Corrupt data"
message added no value.  The latter two error messages misled when the
decrypted payload also exhibited fundamental integrity problems.  Worse,
error message variance in other systems has enabled cryptologic attacks;
see RFC 4880 section "14. Security Considerations".  Whether these
pgcrypto behaviors are likewise exploitable is unknown.

In passing, document that pgcrypto does not resist side-channel attacks.
Back-patch to 9.0 (all supported versions).

Security: CVE-2015-3167
2015-05-18 10:02:31 -04:00
..
expected pgcrypto: Report errant decryption as "Wrong key or corrupt data". 2015-05-18 10:02:31 -04:00
sql pgcrypto: Report errant decryption as "Wrong key or corrupt data". 2015-05-18 10:02:31 -04:00
.gitignore Support "make check" in contrib 2011-04-25 22:27:11 +03:00
Makefile Add functions for dealing with PGP armor header lines to pgcrypto. 2014-10-01 16:03:39 +03:00
blf.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
blf.h Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
crypt-blowfish.c pgcrypto: fix memset() calls that might be optimized away 2014-04-17 12:37:53 -04:00
crypt-des.c Replace a bunch more uses of strncpy() with safer coding. 2015-01-24 13:05:42 -05:00
crypt-gensalt.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
crypt-md5.c pgcrypto: fix memset() calls that might be optimized away 2014-04-17 12:37:53 -04:00
fortuna.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
fortuna.h pgindent run for 9.4 2014-05-06 12:12:18 -04:00
imath.c Cherry-pick security-relevant fixes from upstream imath library. 2015-02-02 10:00:45 -05:00
imath.h pgindent run for 9.4 2014-05-06 12:12:18 -04:00
internal-sha2.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
internal.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
mbuf.c pgcrypto: Report errant decryption as "Wrong key or corrupt data". 2015-05-18 10:02:31 -04:00
mbuf.h pgindent run for 9.4 2014-05-06 12:12:18 -04:00
md5.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
md5.h pgindent run for 9.4 2014-05-06 12:12:18 -04:00
openssl.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
pgcrypto--1.0--1.1.sql Add gen_random_uuid() to contrib/pgcrypto. 2014-01-17 16:52:06 -05:00
pgcrypto--1.1--1.2.sql Add functions for dealing with PGP armor header lines to pgcrypto. 2014-10-01 16:03:39 +03:00
pgcrypto--1.2.sql Fix file-identification comment in contrib/pgcrypto/pgcrypto--1.2.sql. 2014-10-20 10:53:57 -04:00
pgcrypto--unpackaged--1.0.sql Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:37 +02:00
pgcrypto.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
pgcrypto.control Add functions for dealing with PGP armor header lines to pgcrypto. 2014-10-01 16:03:39 +03:00
pgcrypto.h pgindent run for 9.4 2014-05-06 12:12:18 -04:00
pgp-armor.c Add functions for dealing with PGP armor header lines to pgcrypto. 2014-10-01 16:03:39 +03:00
pgp-cfb.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
pgp-compress.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
pgp-decrypt.c pgcrypto: Report errant decryption as "Wrong key or corrupt data". 2015-05-18 10:02:31 -04:00
pgp-encrypt.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
pgp-info.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
pgp-mpi-internal.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
pgp-mpi-openssl.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
pgp-mpi.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
pgp-pgsql.c pgcrypto: Code cleanup for decrypt_internal. 2015-02-04 08:46:32 -05:00
pgp-pubdec.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
pgp-pubenc.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
pgp-pubkey.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
pgp-s2k.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
pgp.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
pgp.h pgcrypto: Report errant decryption as "Wrong key or corrupt data". 2015-05-18 10:02:31 -04:00
px-crypt.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
px-crypt.h pgindent run for 9.4 2014-05-06 12:12:18 -04:00
px-hmac.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
px.c pgcrypto: Report errant decryption as "Wrong key or corrupt data". 2015-05-18 10:02:31 -04:00
px.h pgcrypto: Report errant decryption as "Wrong key or corrupt data". 2015-05-18 10:02:31 -04:00
random.c Prevent Valgrind Memcheck errors around px_acquire_system_randomness(). 2015-02-02 10:00:45 -05:00
rijndael.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
rijndael.h pgindent run for 9.4 2014-05-06 12:12:18 -04:00
rijndael.tbl Remove useless whitespace at end of lines 2010-11-23 22:34:55 +02:00
sha1.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
sha1.h pgindent run for 9.4 2014-05-06 12:12:18 -04:00
sha2.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
sha2.h pgindent run for 9.4 2014-05-06 12:12:18 -04:00