postgresql/src
Bruce Momjian 8c092781f4 ALTER TABLE ... ADD/DROPS INHERIT (actually INHERIT / NO INHERIT)
Open items:

There were a few tangentially related issues that have come up that I think
are TODOs. I'm likely to tackle one or two of these next so I'm interested in
hearing feedback on them as well.

. Constraints currently do not know anything about inheritance. Tom suggested
  adding a coninhcount and conislocal like attributes have to track their
  inheritance status.

. Foreign key constraints currently do not get copied to new children (and
  therefore my code doesn't verify them). I don't think it would be hard to
  add them and treat them like CHECK constraints.

. No constraints at all are copied to tables defined with LIKE. That makes it
  hard to use LIKE to define new partitions. The standard defines LIKE and
  specifically says it does not copy constraints. But the standard already has
  an option called INCLUDING DEFAULTS; we could always define a non-standard
  extension LIKE table INCLUDING CONSTRAINTS that gives the user the option to
  request a copy including constraints.

. Personally, I think the whole attislocal thing is bunk. The decision about
  whether to drop a column from children tables or not is something that
  should be up to the user and trying to DWIM based on whether there was ever
  a local definition or the column was acquired purely through inheritance is
  hardly ever going to match up with user expectations.

. And of course there's the whole unique and primary key constraint issue. I
  think to get any traction at all on this you have a prerequisite of a real
  partitioned table implementation where the system knows what the partition
  key is so it can recognize when it's a leading part of an index key.

Greg Stark
2006-07-02 01:58:36 +00:00
..
backend ALTER TABLE ... ADD/DROPS INHERIT (actually INHERIT / NO INHERIT) 2006-07-02 01:58:36 +00:00
bin Fix memory leak introduced in the prior commit, detected by Tom Lane. 2006-06-30 16:55:35 +00:00
include ALTER TABLE ... ADD/DROPS INHERIT (actually INHERIT / NO INHERIT) 2006-07-02 01:58:36 +00:00
interfaces Add PQescapeIdentifier() to libpq 2006-06-27 00:03:42 +00:00
makefiles Remove dllinit.c; it was only needed for long-obsolete Cygwin versions, 2006-06-22 23:50:35 +00:00
pl Fix Win32/Cygwin problems: 2006-06-25 00:18:24 +00:00
port Add comment about the use of pg_config_paths.h. 2006-06-26 18:40:50 +00:00
template Remove extra 'else' in solaris compiler code. 2006-04-28 04:32:10 +00:00
test ALTER TABLE ... ADD/DROPS INHERIT (actually INHERIT / NO INHERIT) 2006-07-02 01:58:36 +00:00
timezone Prepare code to be built by MSVC: 2006-06-07 22:24:46 +00:00
tools Update cvs command example to show diff -rBASE. 2006-05-31 10:24:29 +00:00
tutorial Remove extremely old, incomplete, broken example code. 2006-06-05 21:16:32 +00:00
DEVELOPERS
Makefile Remove dllinit.c; it was only needed for long-obsolete Cygwin versions, 2006-06-22 23:50:35 +00:00
Makefile.global.in Remove use of lorder and tsort while building static libraries. There's 2006-04-19 16:32:08 +00:00
Makefile.shlib Arrange to strip libpq.so of symbols that aren't officially supposed to 2006-04-28 02:53:20 +00:00
bcc32.mak Add -N make flag to bcc builds from /src dir. 2005-05-13 18:12:35 +00:00
nls-global.mk When merging PO files, take into consideration translations in other PO 2006-04-05 13:40:15 +00:00
win32.mak Fixes for Win32-client only compiles. 2006-03-03 23:11:48 +00:00