mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-08-23 20:47:18 +02:00
The tests of unaccent rely on UTF8 characters, and unlike any other test suite in the tree (fuzzystrmatch, citext, hstore, etc.), they would fail if run on a database that does not support UTF8 encoding. This commit fixes the tests of unaccent so as these are skipped when run on a database without UTF8 support, using the same method as the other test suits based on \if, getdatabaseencoding() and an alternate output file. This has been broken for a long time, but nobody has complained about that either, so no backpatch is done. This can be reproduced with something like REGRESS_OPTS="--no-locale --encoding=sql_ascii", for instance. To defend against that, this module's Makefile and meson.build enforced a UTF8 encoding without locales, but it did not offer protection for options given by REGRESS_OPTS. This switch makes this regression test suite more consistent with all the others, as well. Reviewed-by: Peter Eisentraut Discussion: https://postgr.es/m/ZIq1HUnIV2ksW85x@paquier.xyz
44 lines
1.2 KiB
Makefile
44 lines
1.2 KiB
Makefile
# contrib/unaccent/Makefile
|
|
|
|
MODULE_big = unaccent
|
|
OBJS = \
|
|
$(WIN32RES) \
|
|
unaccent.o
|
|
|
|
EXTENSION = unaccent
|
|
DATA = unaccent--1.1.sql unaccent--1.0--1.1.sql
|
|
DATA_TSEARCH = unaccent.rules
|
|
PGFILEDESC = "unaccent - text search dictionary that removes accents"
|
|
|
|
REGRESS = unaccent
|
|
|
|
ifdef USE_PGXS
|
|
PG_CONFIG = pg_config
|
|
PGXS := $(shell $(PG_CONFIG) --pgxs)
|
|
include $(PGXS)
|
|
else
|
|
subdir = contrib/unaccent
|
|
top_builddir = ../..
|
|
include $(top_builddir)/src/Makefile.global
|
|
include $(top_srcdir)/contrib/contrib-global.mk
|
|
endif
|
|
|
|
update-unicode: $(srcdir)/unaccent.rules
|
|
|
|
# Allow running this even without --with-python
|
|
PYTHON ?= python
|
|
|
|
$(srcdir)/unaccent.rules: generate_unaccent_rules.py ../../src/common/unicode/UnicodeData.txt Latin-ASCII.xml
|
|
$(PYTHON) $< --unicode-data-file $(word 2,$^) --latin-ascii-file $(word 3,$^) >$@
|
|
|
|
# Only download it once; dependencies must match src/common/unicode/
|
|
../../src/common/unicode/UnicodeData.txt: $(top_builddir)/src/Makefile.global
|
|
$(MAKE) -C $(@D) $(@F)
|
|
|
|
# Dependency on Makefile.global is for CLDR_VERSION
|
|
Latin-ASCII.xml: $(top_builddir)/src/Makefile.global
|
|
$(DOWNLOAD) https://raw.githubusercontent.com/unicode-org/cldr/release-$(subst .,-,$(CLDR_VERSION))/common/transforms/Latin-ASCII.xml
|
|
|
|
distclean:
|
|
rm -f Latin-ASCII.xml
|