mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-08-04 03:43:23 +02:00
9fa82c9809
setrefs.c failed to do "rtoffset" adjustment of Vars in RETURNING lists, which meant they were left with the wrong varnos when the RETURNING list was in a subquery. That was never possible before writable CTEs, of course, but now it's broken. The executor fails to notice any problem because ExecEvalVar just references the ecxt_scantuple for any normal varno; but EXPLAIN breaks when the varno is wrong, as illustrated in a recent complaint from Bartosz Dmytrak. Since the eventual rtoffset of the subquery is not known at the time we are preparing its plan node, the previous scheme of executing set_returning_clause_references() at that time cannot handle this adjustment. Fortunately, it turns out that we don't really need to do it that way, because all the needed information is available during normal setrefs.c execution; we just have to dig it out of the ModifyTable node. So, do that, and get rid of the kluge of early setrefs processing of RETURNING lists. (This is a little bit of a cheat in the case of inherited UPDATE/DELETE, because we are not passing a "root" struct that corresponds exactly to what the subplan was built with. But that doesn't matter, and anyway this is less ugly than early setrefs processing was.) Back-patch to 9.1, where the problem became possible to hit. |
||
|---|---|---|
| .. | ||
| clauses.h | ||
| cost.h | ||
| geqo_copy.h | ||
| geqo_gene.h | ||
| geqo_misc.h | ||
| geqo_mutation.h | ||
| geqo_pool.h | ||
| geqo_random.h | ||
| geqo_recombination.h | ||
| geqo_selection.h | ||
| geqo.h | ||
| joininfo.h | ||
| pathnode.h | ||
| paths.h | ||
| placeholder.h | ||
| plancat.h | ||
| planmain.h | ||
| planner.h | ||
| predtest.h | ||
| prep.h | ||
| restrictinfo.h | ||
| subselect.h | ||
| tlist.h | ||
| var.h | ||