mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-07-23 12:39:39 +02:00
e85662df44
Currently, pg_visibility computes its xid horizon using the GetOldestNonRemovableTransactionId(). The problem is that this horizon can sometimes go backward. That can lead to reporting false errors. In order to fix that, this commit implements a new function GetStrictOldestNonRemovableTransactionId(). This function computes the xid horizon, which would be guaranteed to be newer or equal to any xid horizon computed before. We have to do the following to achieve this. 1. Ignore processes xmin's, because they consider connection to other databases that were ignored before. 2. Ignore KnownAssignedXids, because they are not database-aware. At the same time, the primary could compute its horizons database-aware. 3. Ignore walsender xmin, because it could go backward if some replication connections don't use replication slots. As a result, we're using only currently running xids to compute the horizon. Surely these would significantly sacrifice accuracy. But we have to do so to avoid reporting false errors. Inspired by earlier patch by Daniel Shelepanov and the following discussion with Robert Haas and Tom Lane. Discussion: https://postgr.es/m/1649062270.289865713%40f403.i.mail.ru Reviewed-by: Alexander Lakhin, Dmitry Koval
26 lines
562 B
Makefile
26 lines
562 B
Makefile
# contrib/pg_visibility/Makefile
|
|
|
|
MODULE_big = pg_visibility
|
|
OBJS = \
|
|
$(WIN32RES) \
|
|
pg_visibility.o
|
|
|
|
EXTENSION = pg_visibility
|
|
DATA = pg_visibility--1.1.sql pg_visibility--1.1--1.2.sql \
|
|
pg_visibility--1.0--1.1.sql
|
|
PGFILEDESC = "pg_visibility - page visibility information"
|
|
|
|
REGRESS = pg_visibility
|
|
TAP_TESTS = 1
|
|
|
|
ifdef USE_PGXS
|
|
PG_CONFIG = pg_config
|
|
PGXS := $(shell $(PG_CONFIG) --pgxs)
|
|
include $(PGXS)
|
|
else
|
|
subdir = contrib/pg_visibility
|
|
top_builddir = ../..
|
|
include $(top_builddir)/src/Makefile.global
|
|
include $(top_srcdir)/contrib/contrib-global.mk
|
|
endif
|