postgresql/contrib/postgres_fdw
Michael Paquier d61a361d1a Remove all traces of tuplestore_donestoring() in the C code
This routine is a no-op since dd04e95 from 2003, with a macro kept
around for compatibility purposes.  This has led to the same code
patterns being copy-pasted around for no effect, sometimes in confusing
ways like in pg_logical_slot_get_changes_guts() from logical.c where the
code was actually incorrect.

This issue has been discussed on two different threads recently, so
rather than living with this legacy, remove any uses of this routine in
the C code to simplify things.  The compatibility macro is kept to avoid
breaking any out-of-core modules that depend on it.

Reported-by: Tatsuhito Kasahara, Justin Pryzby
Author: Tatsuhito Kasahara
Discussion: https://postgr.es/m/20211217200419.GQ17618@telsasoft.com
Discussion: https://postgr.es/m/CAP0=ZVJeeYfAeRfmzqAF2Lumdiv4S4FewyBnZd4DPTrsSQKJKw@mail.gmail.com
2022-02-17 09:52:02 +09:00
..
expected postgres_fdw: Fix handling of a pending asynchronous request in postgresReScanForeignScan(). 2022-01-27 16:15:00 +09:00
sql postgres_fdw: Fix handling of a pending asynchronous request in postgresReScanForeignScan(). 2022-01-27 16:15:00 +09:00
.gitignore Add postgres_fdw contrib module. 2013-02-21 05:27:16 -05:00
Makefile postgres_fdw: Add function to list cached connections to foreign servers. 2021-01-18 15:11:08 +09:00
connection.c Remove all traces of tuplestore_donestoring() in the C code 2022-02-17 09:52:02 +09:00
deparse.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
option.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
postgres_fdw--1.0--1.1.sql postgres_fdw: Add functions to discard cached connections. 2021-01-26 15:35:54 +09:00
postgres_fdw--1.0.sql Add postgres_fdw contrib module. 2013-02-21 05:27:16 -05:00
postgres_fdw.c postgres_fdw: Fix handling of a pending asynchronous request in postgresReScanForeignScan(). 2022-01-27 16:15:00 +09:00
postgres_fdw.control postgres_fdw: Add function to list cached connections to foreign servers. 2021-01-18 15:11:08 +09:00
postgres_fdw.h Update copyright for 2022 2022-01-07 19:04:57 -05:00
shippable.c Update copyright for 2022 2022-01-07 19:04:57 -05:00