postgresql/src/port
Heikki Linnakangas ff30aec759 Fix and simplify check for whether we're running as Windows service.
If the process token contains SECURITY_SERVICE_RID, but it has been
disabled by the SE_GROUP_USE_FOR_DENY_ONLY attribute, win32_is_service()
would incorrectly report that we're running as a service. That situation
arises, e.g. if postmaster is launched with a restricted security token,
with the "Log in as Service" privilege explicitly removed.

Replace the broken code with CheckProcessTokenMembership(), which does
this correctly. Also replace similar code in win32_is_admin(), even
though it got this right, for simplicity and consistency.

Per bug #13755, reported by Breen Hagan. Back-patch to all supported
versions. Patch by Takayuki Tsunakawa, reviewed by Michael Paquier.

Discussion: https://www.postgresql.org/message-id/20151104062315.2745.67143%40wrigleys.postgresql.org
2017-03-17 11:14:01 +02:00
..
.gitignore
chklocale.c
crypt.c
dirent.c
dirmod.c Put back #include <windows.h> in dirmod.c. 2017-02-25 18:34:09 -05:00
erand48.c
fls.c
fseeko.c
getaddrinfo.c
getopt_long.c
getopt.c
getpeereid.c
getrusage.c
gettimeofday.c
inet_aton.c
inet_net_ntop.c
isinf.c
kill.c
Makefile
mkdtemp.c
noblock.c
open.c
path.c
pg_crc32c_choose.c
pg_crc32c_sb8.c
pg_crc32c_sse42.c
pg_strong_random.c
pgcheckdir.c
pgmkdirp.c
pgsleep.c
pgstrcasecmp.c
pqsignal.c
pthread-win32.h
qsort_arg.c
qsort.c
quotes.c
random.c
README
rint.c
snprintf.c
sprompt.c
srandom.c
strerror.c
strlcat.c
strlcpy.c
system.c
tar.c
thread.c
unsetenv.c
win32.ico
win32env.c
win32error.c
win32security.c Fix and simplify check for whether we're running as Windows service. 2017-03-17 11:14:01 +02:00
win32setlocale.c
win32ver.rc

src/port/README

libpgport
=========

libpgport must have special behavior.  It supplies functions to both
libraries and applications.  However, there are two complexities:

1)  Libraries need to use object files that are compiled with exactly
the same flags as the library.  libpgport might not use the same flags,
so it is necessary to recompile the object files for individual
libraries.  This is done by removing -lpgport from the link line:

        # Need to recompile any libpgport object files
        LIBS := $(filter-out -lpgport, $(LIBS))

and adding infrastructure to recompile the object files:

        OBJS= execute.o typename.o descriptor.o data.o error.o prepare.o memory.o \
                connect.o misc.o path.o exec.o \
                $(filter snprintf.o, $(LIBOBJS))

The problem is that there is no testing of which object files need to be
added, but missing functions usually show up when linking user
applications.

2) For applications, we use -lpgport before -lpq, so the static files
from libpgport are linked first.  This avoids having applications
dependent on symbols that are _used_ by libpq, but not intended to be
exported by libpq.  libpq's libpgport usage changes over time, so such a
dependency is a problem.  Windows, Linux, and macOS use an export list to
control the symbols exported by libpq.