postgresql/src/port
Thomas Munro 6969deeb8d Handle ReadFile() EOF correctly on Windows.
When ReadFile() encounters the end of a file while reading from
a synchronous handle with an offset provided via OVERLAPPED, it
reports an error instead of returning 0.  By not handling that
(undocumented) result correctly, we caused some noisy LOG
messages about an unknown error code.  Repair.

Back-patch to 12, where we started using pread()/ReadFile() with
an offset.

Reported-by: ZhenHua Cai, Amit Kapila
Diagnosed-by: Juan Jose Santamaria Flecha
Tested-by: Amit Kapila
Discussion: https://postgr.es/m/CAA4eK1LK3%2BWRtpz68TiRdpHwxxWm%3D%2Bt1BMf-G68hhQsAQ41PZg%40mail.gmail.com
2019-11-20 18:29:37 +13:00
..
.gitignore Build src/port files as a library with -fPIC, and use that in libpq. 2018-09-27 11:23:43 -04:00
chklocale.c Remove some code for old unsupported versions of MSVC 2019-10-08 10:50:54 +02:00
dirent.c Fix error handling of readdir() port implementation on first file lookup 2019-03-04 09:49:06 +09:00
dirmod.c Update copyright for 2019 2019-01-02 12:44:25 -05:00
dlopen.c Initial pgindent run for v12. 2019-05-22 12:55:34 -04:00
erand48.c Update copyright for 2019 2019-01-02 12:44:25 -05:00
explicit_bzero.c Use explicit_bzero 2019-09-05 08:30:42 +02:00
fls.c Update copyright for 2019 2019-01-02 12:44:25 -05:00
fseeko.c Update copyright for 2019 2019-01-02 12:44:25 -05:00
getaddrinfo.c Avoid conflicts with library versions of inet_net_ntop() and friends. 2019-08-18 19:27:23 -04:00
getopt_long.c Phase 3 of pgindent updates. 2017-06-21 15:35:54 -04:00
getopt.c Use our own getopt() on OpenBSD. 2019-01-18 15:06:26 -05:00
getpeereid.c Update copyright for 2019 2019-01-02 12:44:25 -05:00
getrusage.c Update copyright for 2019 2019-01-02 12:44:25 -05:00
gettimeofday.c Phase 3 of pgindent updates. 2017-06-21 15:35:54 -04:00
inet_aton.c Correct include file name in inet_aton fallback. 2017-10-01 17:41:00 -07:00
inet_net_ntop.c Avoid conflicts with library versions of inet_net_ntop() and friends. 2019-08-18 19:27:23 -04:00
isinf.c ANSI-ify a few straggler K&R-style function definitions. 2019-05-18 20:16:50 -04:00
kill.c Update copyright for 2019 2019-01-02 12:44:25 -05:00
Makefile Split all OBJS style lines in makefiles into one-line-per-entry style. 2019-11-05 14:41:07 -08:00
mkdtemp.c Update copyright for 2019 2019-01-02 12:44:25 -05:00
noblock.c Update copyright for 2019 2019-01-02 12:44:25 -05:00
open.c Assert that pgwin32_signal_initialize() has been called early enough. 2019-04-03 17:11:16 -07:00
path.c Phase 2 pgindent run for v12. 2019-05-22 13:04:48 -04:00
pg_bitutils.c Fix typos and inconsistencies in code comments 2019-06-14 09:34:34 +09:00
pg_crc32c_armv8_choose.c Update copyright for 2019 2019-01-02 12:44:25 -05:00
pg_crc32c_armv8.c Make the order of the header file includes consistent in non-backend modules. 2019-10-25 07:41:52 +05:30
pg_crc32c_sb8.c Update copyright for 2019 2019-01-02 12:44:25 -05:00
pg_crc32c_sse42_choose.c Update copyright for 2019 2019-01-02 12:44:25 -05:00
pg_crc32c_sse42.c Make the order of the header file includes consistent in non-backend modules. 2019-10-25 07:41:52 +05:30
pg_strong_random.c Fix compiler warning 2019-09-01 23:19:51 +02:00
pgcheckdir.c Update copyright for 2019 2019-01-02 12:44:25 -05:00
pgmkdirp.c Fix various typos and grammar errors in comments. 2015-04-26 18:42:31 +02:00
pgsleep.c Update copyright for 2019 2019-01-02 12:44:25 -05:00
pgstrcasecmp.c Update copyright for 2019 2019-01-02 12:44:25 -05:00
pgstrsignal.c Improve what pg_strsignal prints if we haven't got strsignal(3). 2019-08-27 17:24:47 -04:00
pqsignal.c In the postmaster, rely on the signal infrastructure to block signals. 2019-10-13 15:48:26 -04:00
pread.c Handle ReadFile() EOF correctly on Windows. 2019-11-20 18:29:37 +13:00
pthread-win32.h Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
pwrite.c Fix more typos and inconsistencies in the tree 2019-06-17 16:13:16 +09:00
qsort_arg.c Phase 2 pgindent run for v12. 2019-05-22 13:04:48 -04:00
qsort.c Phase 2 pgindent run for v12. 2019-05-22 13:04:48 -04:00
quotes.c Update copyright for 2019 2019-01-02 12:44:25 -05:00
random.c Update copyright for 2019 2019-01-02 12:44:25 -05:00
README Always use our own versions of *printf(). 2018-09-26 13:13:57 -04:00
rint.c Rethink how to get float.h in old Windows API for isnan/isinf 2018-07-11 09:11:48 -04:00
snprintf.c Fix most -Wundef warnings 2019-10-19 18:31:38 +02:00
sprompt.c Fix failures to ignore \r when reading Windows-style newlines. 2019-07-25 12:11:17 -04:00
srandom.c Update copyright for 2019 2019-01-02 12:44:25 -05:00
strerror.c Update copyright for 2019 2019-01-02 12:44:25 -05:00
strlcat.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
strlcpy.c Update copyright for 2019 2019-01-02 12:44:25 -05:00
strnlen.c Update copyright for 2019 2019-01-02 12:44:25 -05:00
strtof.c Initial pgindent run for v12. 2019-05-22 12:55:34 -04:00
system.c Update copyright for 2019 2019-01-02 12:44:25 -05:00
tar.c Make the order of the header file includes consistent in non-backend modules. 2019-10-25 07:41:52 +05:30
thread.c Fix inconsistencies and typos in the tree 2019-07-16 13:23:53 +09:00
unsetenv.c Update copyright for 2019 2019-01-02 12:44:25 -05:00
win32.ico Revert binary change in copyright year adjustment. 2012-01-01 19:40:13 -05:00
win32env.c Update copyright for 2019 2019-01-02 12:44:25 -05:00
win32error.c Fix most -Wundef warnings 2019-10-19 18:31:38 +02:00
win32security.c Update copyright for 2019 2019-01-02 12:44:25 -05:00
win32setlocale.c Deal with yet another issue related to "Norwegian (Bokmål)" locale. 2019-10-21 14:18:01 -04:00
win32ver.rc Stamp HEAD as 13devel. 2019-07-01 12:50:55 -04:00

src/port/README

libpgport
=========

libpgport must have special behavior.  It supplies functions to both
libraries and applications.  However, there are two complexities:

1)  Libraries need to use object files that are compiled with exactly
the same flags as the library.  libpgport might not use the same flags,
so it is necessary to recompile the object files for individual
libraries.  This is done by removing -lpgport from the link line:

        # Need to recompile any libpgport object files
        LIBS := $(filter-out -lpgport, $(LIBS))

and adding infrastructure to recompile the object files:

        OBJS= execute.o typename.o descriptor.o data.o error.o prepare.o memory.o \
                connect.o misc.o path.o exec.o \
                $(filter strlcat.o, $(LIBOBJS))

The problem is that there is no testing of which object files need to be
added, but missing functions usually show up when linking user
applications.

2) For applications, we use -lpgport before -lpq, so the static files
from libpgport are linked first.  This avoids having applications
dependent on symbols that are _used_ by libpq, but not intended to be
exported by libpq.  libpq's libpgport usage changes over time, so such a
dependency is a problem.  Windows, Linux, and macOS use an export list to
control the symbols exported by libpq.