Tom Lane 696b0c5fd0 Fix memory leak in repeated SPGIST index scans. ... spgendscan neglected to pfree all the memory allocated by spgbeginscan. It's possible to get away with that in most normal queries, since the memory is allocated in the executor's per-query context which is about to get deleted anyway; but it causes severe memory leakage during creation or filling of large exclusion-constraint indexes. Also, document that amendscan is supposed to free what ambeginscan allocates. The docs' lack of clarity on that point probably caused this bug to begin with. (There is discussion of changing that API spec going forward, but I don't think it'd be appropriate for the back branches.) Per report from Bruno Wolff. It's been like this since the beginning, so back-patch to all active branches. In HEAD, also fix an independent leak caused by commit 2a6368343 (allocating memory during spgrescan instead of spgbeginscan, which might be all right if it got cleaned up, but it didn't). And do a bit of code beautification on that commit, too. Discussion: https://postgr.es/m/20181024012314.GA27428@wolff.to		2018-10-31 17:05:03 -04:00
..
src	Fix memory leak in repeated SPGIST index scans.	2018-10-31 17:05:03 -04:00
KNOWN_BUGS	Remove extra newlines at end and beginning of files, add missing newlines	2010-08-19 05:57:36 +00:00
MISSING_FEATURES	Remove extra newlines at end and beginning of files, add missing newlines	2010-08-19 05:57:36 +00:00
Makefile	Remove maintainer-check target, fold into normal build	2013-10-10 20:11:56 -04:00
TODO	Change documentation references to PG website to use https: not http:	2017-05-20 21:50:47 -04:00
bug.template	Stamp HEAD as 12devel	2018-06-30 12:47:59 -04:00