mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-07-25 07:19:38 +02:00
f18aa1b203
Block numbers are 32-bit unsigned integers. Therefore, the smallest SQL integer type that they can fit in is bigint. However, in the pageinspect module, most input and output parameters dealing with block numbers were declared as int. The behavior with block numbers larger than a signed 32-bit integer was therefore dubious. Change these arguments to type bigint and add some more explicit error checking on the block range. (Other contrib modules appear to do this correctly already.) Since we are changing argument types of existing functions, in order to not misbehave if the binary is updated before the extension is updated, we need to create new C symbols for the entry points, similar to how it's done in other extensions as well. Reported-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org> Reviewed-by: Michael Paquier <michael@paquier.xyz> Discussion: https://www.postgresql.org/message-id/flat/d8f6bdd536df403b9b33816e9f7e0b9d@G08CNEXMBPEKD05.g08.fujitsu.local |
||
|---|---|---|
| .. | ||
| expected | ||
| sql | ||
| .gitignore | ||
| brinfuncs.c | ||
| btreefuncs.c | ||
| fsmfuncs.c | ||
| ginfuncs.c | ||
| gistfuncs.c | ||
| hashfuncs.c | ||
| heapfuncs.c | ||
| Makefile | ||
| pageinspect--1.0--1.1.sql | ||
| pageinspect--1.1--1.2.sql | ||
| pageinspect--1.2--1.3.sql | ||
| pageinspect--1.3--1.4.sql | ||
| pageinspect--1.4--1.5.sql | ||
| pageinspect--1.5--1.6.sql | ||
| pageinspect--1.5.sql | ||
| pageinspect--1.6--1.7.sql | ||
| pageinspect--1.7--1.8.sql | ||
| pageinspect--1.8--1.9.sql | ||
| pageinspect.control | ||
| pageinspect.h | ||
| rawpage.c | ||