mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-10-02 19:56:53 +02:00
a9632830bb
It's intentional that we don't allow values greater than 24 hours, while we do allow "24:00:00" as well as "23:59:60" as inputs. However, the range check was miscoded in such a way that it would accept "23:59:60.nnn" with a nonzero fraction. For time or timetz, the stored result would then be greater than "24:00:00" which would fail dump/reload, not to mention possibly confusing other operations. Fix by explicitly calculating the result and making sure it does not exceed 24 hours. (This calculation is redundant with what will happen later in tm2time or tm2timetz. Maybe someday somebody will find that annoying enough to justify refactoring to avoid the duplication; but that seems too invasive for a back-patched bug fix, and the cost is probably unmeasurable anyway.) Note that this change also rejects such input as the time portion of a timestamp(tz) value. Back-patch to v10. The bug is far older, but to change this pre-v10 we'd need to ensure that the logic behaves sanely with float timestamps, which is possibly nontrivial due to roundoff considerations. Doesn't really seem worth troubling with. Per report from Christoph Berg. Discussion: https://postgr.es/m/20200520125807.GB296739@msg.df7cb.de
88 lines
3.0 KiB
C
88 lines
3.0 KiB
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* date.h
|
|
* Definitions for the SQL "date" and "time" types.
|
|
*
|
|
*
|
|
* Portions Copyright (c) 1996-2020, PostgreSQL Global Development Group
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
*
|
|
* src/include/utils/date.h
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
#ifndef DATE_H
|
|
#define DATE_H
|
|
|
|
#include <math.h>
|
|
|
|
#include "datatype/timestamp.h"
|
|
#include "fmgr.h"
|
|
#include "pgtime.h"
|
|
|
|
typedef int32 DateADT;
|
|
|
|
typedef int64 TimeADT;
|
|
|
|
typedef struct
|
|
{
|
|
TimeADT time; /* all time units other than months and years */
|
|
int32 zone; /* numeric time zone, in seconds */
|
|
} TimeTzADT;
|
|
|
|
/*
|
|
* Infinity and minus infinity must be the max and min values of DateADT.
|
|
*/
|
|
#define DATEVAL_NOBEGIN ((DateADT) PG_INT32_MIN)
|
|
#define DATEVAL_NOEND ((DateADT) PG_INT32_MAX)
|
|
|
|
#define DATE_NOBEGIN(j) ((j) = DATEVAL_NOBEGIN)
|
|
#define DATE_IS_NOBEGIN(j) ((j) == DATEVAL_NOBEGIN)
|
|
#define DATE_NOEND(j) ((j) = DATEVAL_NOEND)
|
|
#define DATE_IS_NOEND(j) ((j) == DATEVAL_NOEND)
|
|
#define DATE_NOT_FINITE(j) (DATE_IS_NOBEGIN(j) || DATE_IS_NOEND(j))
|
|
|
|
/*
|
|
* Macros for fmgr-callable functions.
|
|
*
|
|
* For TimeADT, we make use of the same support routines as for int64.
|
|
* Therefore TimeADT is pass-by-reference if and only if int64 is!
|
|
*/
|
|
#define MAX_TIME_PRECISION 6
|
|
|
|
#define DatumGetDateADT(X) ((DateADT) DatumGetInt32(X))
|
|
#define DatumGetTimeADT(X) ((TimeADT) DatumGetInt64(X))
|
|
#define DatumGetTimeTzADTP(X) ((TimeTzADT *) DatumGetPointer(X))
|
|
|
|
#define DateADTGetDatum(X) Int32GetDatum(X)
|
|
#define TimeADTGetDatum(X) Int64GetDatum(X)
|
|
#define TimeTzADTPGetDatum(X) PointerGetDatum(X)
|
|
|
|
#define PG_GETARG_DATEADT(n) DatumGetDateADT(PG_GETARG_DATUM(n))
|
|
#define PG_GETARG_TIMEADT(n) DatumGetTimeADT(PG_GETARG_DATUM(n))
|
|
#define PG_GETARG_TIMETZADT_P(n) DatumGetTimeTzADTP(PG_GETARG_DATUM(n))
|
|
|
|
#define PG_RETURN_DATEADT(x) return DateADTGetDatum(x)
|
|
#define PG_RETURN_TIMEADT(x) return TimeADTGetDatum(x)
|
|
#define PG_RETURN_TIMETZADT_P(x) return TimeTzADTPGetDatum(x)
|
|
|
|
|
|
/* date.c */
|
|
extern int32 anytime_typmod_check(bool istz, int32 typmod);
|
|
extern double date2timestamp_no_overflow(DateADT dateVal);
|
|
extern Timestamp date2timestamp_opt_overflow(DateADT dateVal, int *overflow);
|
|
extern TimestampTz date2timestamptz_opt_overflow(DateADT dateVal, int *overflow);
|
|
extern void EncodeSpecialDate(DateADT dt, char *str);
|
|
extern DateADT GetSQLCurrentDate(void);
|
|
extern TimeTzADT *GetSQLCurrentTime(int32 typmod);
|
|
extern TimeADT GetSQLLocalTime(int32 typmod);
|
|
extern int time2tm(TimeADT time, struct pg_tm *tm, fsec_t *fsec);
|
|
extern int timetz2tm(TimeTzADT *time, struct pg_tm *tm, fsec_t *fsec, int *tzp);
|
|
extern int tm2time(struct pg_tm *tm, fsec_t fsec, TimeADT *result);
|
|
extern int tm2timetz(struct pg_tm *tm, fsec_t fsec, int tz, TimeTzADT *result);
|
|
extern bool time_overflows(int hour, int min, int sec, fsec_t fsec);
|
|
extern bool float_time_overflows(int hour, int min, double sec);
|
|
extern void AdjustTimeForTypmod(TimeADT *time, int32 typmod);
|
|
|
|
#endif /* DATE_H */
|