mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-08-21 22:53:23 +02:00
repeatedly. Now that we don't have to worry about memory leaks from glibc's qsort, we can safely put CHECK_FOR_INTERRUPTS into the tuplesort comparators, as was requested a couple months ago. Also, get rid of non-reentrancy and an extra level of function call in tuplesort.c by providing a variant qsort_arg() API that passes an extra void * argument through to the comparison routine. (We might want to use that in other places too, I didn't look yet.) |
||
---|---|---|
.. | ||
copydir.c | ||
crypt.c | ||
dirent.c | ||
dirmod.c | ||
exec.c | ||
fseeko.c | ||
getaddrinfo.c | ||
gethostname.c | ||
getopt_long.c | ||
getopt.c | ||
getrusage.c | ||
gettimeofday.c | ||
inet_aton.c | ||
isinf.c | ||
kill.c | ||
Makefile | ||
memcmp.c | ||
noblock.c | ||
open.c | ||
path.c | ||
pgsleep.c | ||
pgstrcasecmp.c | ||
pipe.c | ||
pthread-win32.h | ||
qsort_arg.c | ||
qsort.c | ||
rand.c | ||
random.c | ||
README | ||
rint.c | ||
snprintf.c | ||
sprompt.c | ||
srandom.c | ||
strdup.c | ||
strerror.c | ||
strlcpy.c | ||
strtol.c | ||
strtoul.c | ||
thread.c | ||
unsetenv.c | ||
win32.ico | ||
win32error.c | ||
win32ver.rc |
libpgport must have special behavior. It supplies functions to both libraries and applications. However, there are two complexities: 1) Libraries need to use object files that are compiled with exactly the same flags as the library. libpgport might not use the same flags, so it is necessary to recompile the object files for individual libraries. This is done by removing -lpgport from the link line: # Need to recompile any libpgport object files LIBS := $(filter-out -lpgport, $(LIBS)) and adding infrastructure to recompile the object files: OBJS= execute.o typename.o descriptor.o data.o error.o prepare.o memory.o \ connect.o misc.o path.o exec.o \ $(filter snprintf.o, $(LIBOBJS)) The problem is that there is no testing of which object files need to be added, but missing functions usually show up when linking user applications. 2) For applications, we use -lpgport before -lpq, so the static files from libpgport are linked first. This avoids having applications dependent on symbols that are _used_ by libpq, but not intended to be exported by libpq. libpq's libpgport usage changes over time, so such a dependency is a problem. Win32, Linux, and Darwin use an export list to control the symbols exported by libpq.