mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-07-15 15:51:10 +02:00
9d41ecfcd9
Attempting to use this function with a raw page not coming from a GiST
index would cause a crash, as it was missing the same sanity checks as
gist_page_items_bytea(). This slightly refactors the code so as all the
basic validation checks for GiST pages are done in a single routine,
in the same fashion as the pageinspect functions for hash and BRIN.
This fixes an issue similar to 076f4d9. A test is added to stress for
this case. While on it, I have added a similar test for
brin_page_items() with a combination make of a valid GiST index and a
raw btree page. This one was already protected, but it was not tested.
Reported-by: Egor Chindyaskin
Author: Dmitry Koval
Discussion: https://postgr.es/m/17815-fc4a2d3b74705703@postgresql.org
Backpatch-through: 14
93 lines
2.8 KiB
Plaintext
93 lines
2.8 KiB
Plaintext
CREATE TABLE test1 (a int, b text);
|
|
INSERT INTO test1 VALUES (1, 'one');
|
|
CREATE INDEX test1_a_idx ON test1 USING brin (a);
|
|
SELECT brin_page_type(get_raw_page('test1_a_idx', 0));
|
|
brin_page_type
|
|
----------------
|
|
meta
|
|
(1 row)
|
|
|
|
SELECT brin_page_type(get_raw_page('test1_a_idx', 1));
|
|
brin_page_type
|
|
----------------
|
|
revmap
|
|
(1 row)
|
|
|
|
SELECT brin_page_type(get_raw_page('test1_a_idx', 2));
|
|
brin_page_type
|
|
----------------
|
|
regular
|
|
(1 row)
|
|
|
|
SELECT * FROM brin_metapage_info(get_raw_page('test1_a_idx', 0));
|
|
magic | version | pagesperrange | lastrevmappage
|
|
------------+---------+---------------+----------------
|
|
0xA8109CFA | 1 | 128 | 1
|
|
(1 row)
|
|
|
|
SELECT * FROM brin_metapage_info(get_raw_page('test1_a_idx', 1));
|
|
ERROR: page is not a BRIN page of type "metapage"
|
|
DETAIL: Expected special type 0000f091, got 0000f092.
|
|
SELECT * FROM brin_revmap_data(get_raw_page('test1_a_idx', 0)) LIMIT 5;
|
|
ERROR: page is not a BRIN page of type "revmap"
|
|
DETAIL: Expected special type 0000f092, got 0000f091.
|
|
SELECT * FROM brin_revmap_data(get_raw_page('test1_a_idx', 1)) LIMIT 5;
|
|
pages
|
|
-------
|
|
(2,1)
|
|
(0,0)
|
|
(0,0)
|
|
(0,0)
|
|
(0,0)
|
|
(5 rows)
|
|
|
|
SELECT * FROM brin_page_items(get_raw_page('test1_a_idx', 2), 'test1_a_idx')
|
|
ORDER BY blknum, attnum LIMIT 5;
|
|
itemoffset | blknum | attnum | allnulls | hasnulls | placeholder | value
|
|
------------+--------+--------+----------+----------+-------------+----------
|
|
1 | 0 | 1 | f | f | f | {1 .. 1}
|
|
(1 row)
|
|
|
|
-- Mask DETAIL messages as these are not portable across architectures.
|
|
\set VERBOSITY terse
|
|
-- Failures for non-BRIN index.
|
|
CREATE INDEX test1_a_btree ON test1 (a);
|
|
SELECT brin_page_items(get_raw_page('test1_a_btree', 0), 'test1_a_btree');
|
|
ERROR: "test1_a_btree" is not a BRIN index
|
|
SELECT brin_page_items(get_raw_page('test1_a_btree', 0), 'test1_a_idx');
|
|
ERROR: input page is not a valid BRIN page
|
|
-- Invalid special area size
|
|
SELECT brin_page_type(get_raw_page('test1', 0));
|
|
ERROR: input page is not a valid BRIN page
|
|
SELECT * FROM brin_metapage_info(get_raw_page('test1', 0));
|
|
ERROR: input page is not a valid BRIN page
|
|
SELECT * FROM brin_revmap_data(get_raw_page('test1', 0));
|
|
ERROR: input page is not a valid BRIN page
|
|
\set VERBOSITY default
|
|
-- Tests with all-zero pages.
|
|
SHOW block_size \gset
|
|
SELECT brin_page_type(decode(repeat('00', :block_size), 'hex'));
|
|
brin_page_type
|
|
----------------
|
|
|
|
(1 row)
|
|
|
|
SELECT brin_page_items(decode(repeat('00', :block_size), 'hex'), 'test1_a_idx');
|
|
brin_page_items
|
|
-----------------
|
|
(0 rows)
|
|
|
|
SELECT brin_metapage_info(decode(repeat('00', :block_size), 'hex'));
|
|
brin_metapage_info
|
|
--------------------
|
|
|
|
(1 row)
|
|
|
|
SELECT brin_revmap_data(decode(repeat('00', :block_size), 'hex'));
|
|
brin_revmap_data
|
|
------------------
|
|
|
|
(1 row)
|
|
|
|
DROP TABLE test1;
|