postgresql

mirror of https://git.postgresql.org/git/postgresql.git synced 2024-08-26 08:47:20 +02:00

History

Tom Lane 70b42f2790 Fix misbehavior of EvalPlanQual checks with multiple result relations. The idea of EvalPlanQual is that we replace the query's scan of the result relation with a single injected tuple, and see if we get a tuple out, thereby implying that the injected tuple still passes the query quals. (In join cases, other relations in the query are still scanned normally.) This logic was not updated when commit `86dc90056` made it possible for a single DML query plan to have multiple result relations, when the query target relation has inheritance or partition children. We replaced the output for the current result relation successfully, but other result relations were still scanned normally; thus, if any other result relation contained a tuple satisfying the quals, we'd think the EPQ check passed, even if it did not pass for the injected tuple itself. This would lead to update or delete actions getting performed when they should have been skipped due to a conflicting concurrent update in READ COMMITTED isolation mode. Fix by blocking all sibling result relations from emitting tuples during an EvalPlanQual recheck. In the back branches, the fix is complicated a bit by the need to not change the size of struct EPQState (else we'd have ABI-breaking changes in offsets in struct ModifyTableState). Like the back-patches of `3f7836ff6` and `4b3e37993`, add a separately palloc'd struct to avoid that. The logic is the same as in HEAD otherwise. This is only a live bug back to v14 where `86dc90056` came in. However, I chose to back-patch the test cases further, on the grounds that this whole area is none too well tested. I skipped doing so in v11 though because none of the test applied cleanly, and it didn't quite seem worth extra work for a branch with only six months to live. Per report from Ante Krešić (via Aleksander Alekseev) Discussion: https://postgr.es/m/CAJ7c6TMBTN3rcz4=AjYhLPD_w3FFT0Wq_C15jxCDn8U4tZnH1g@mail.gmail.com		2023-05-19 14:26:40 -04:00
..
authentication	libpq: Error message improvement	2023-05-16 08:59:34 +02:00
examples	Update copyright for 2023	2023-01-02 15:00:37 -05:00
icu	initdb: derive encoding from locale for ICU; similar to libc.	2023-03-10 10:51:24 -08:00
isolation	Fix misbehavior of EvalPlanQual checks with multiple result relations.	2023-05-19 14:26:40 -04:00
kerberos	libpq: Error message improvement	2023-05-16 08:59:34 +02:00
ldap	Fix various typos	2023-04-18 13:23:23 +12:00
locale	Update copyright for 2023	2023-01-02 15:00:37 -05:00
mb	Fix MB regression tests for WAL-logging of hash indexes.	2017-03-15 07:25:36 -04:00
modules	Show empty BRIN ranges in brin_page_items	2023-05-19 02:00:21 +02:00
perl	Add missing uninstallation rule for BackgroundPsql.pm	2023-05-02 09:41:03 +02:00
recovery	Fix the race condition in the test case added by commit `a6e04b1d20`.	2023-05-09 14:25:33 +05:30
regress	Avoid naming conflict between transactions.sql and namespace.sql.	2023-05-19 10:57:46 -04:00
ssl	Fix errormessage for missing system CA in OpenSSL 3.1	2023-04-19 12:54:58 +02:00
subscription	Fix typos in comments	2023-05-02 12:23:08 +09:00
Makefile	Refactor PG_TEST_EXTRA logic in autoconf build	2022-09-20 11:24:16 -07:00
meson.build	Update copyright for 2023	2023-01-02 15:00:37 -05:00
README	Remove the option to build thread_test.c outside configure.	2020-10-21 12:08:48 -04:00

README

PostgreSQL tests
================

This directory contains a variety of test infrastructure as well as some of the
tests in PostgreSQL. Not all tests are here -- in particular, there are more in
individual contrib/ modules and in src/bin.

Not all these tests get run by "make check". Check src/test/Makefile to see
which tests get run automatically.

authentication/
  Tests for authentication (but see also below)

examples/
  Demonstration programs for libpq that double as regression tests via
  "make check"

isolation/
  Tests for concurrent behavior at the SQL level

kerberos/
  Tests for Kerberos/GSSAPI authentication and encryption

ldap/
  Tests for LDAP-based authentication

locale/
  Sanity checks for locale data, encodings, etc

mb/
  Tests for multibyte encoding (UTF-8) support

modules/
  Extensions used only or mainly for test purposes, generally not suitable
  for installing in production databases

perl/
  Infrastructure for Perl-based TAP tests

recovery/
  Test suite for recovery and replication

regress/
  PostgreSQL's main regression test suite, pg_regress

ssl/
  Tests to exercise and verify SSL certificate handling

subscription/
  Tests for logical replication