postgresql/contrib/pg_upgrade
Tom Lane 785941cdc3 Tweak __attribute__-wrapping macros for better pgindent results.
This improves on commit bbfd7edae5 by
making two simple changes:

* pg_attribute_noreturn now takes parentheses, ie pg_attribute_noreturn().
Likewise pg_attribute_unused(), pg_attribute_packed().  This reduces
pgindent's tendency to misformat declarations involving them.

* attributes are now always attached to function declarations, not
definitions.  Previously some places were taking creative shortcuts,
which were not merely candidates for bad misformatting by pgindent
but often were outright wrong anyway.  (It does little good to put a
noreturn annotation where callers can't see it.)  In any case, if
we would like to believe that these macros can be used with non-gcc
compilers, we should avoid gratuitous variance in usage patterns.

I also went through and manually improved the formatting of a lot of
declarations, and got rid of excessively repetitive (and now obsolete
anyway) comments informing the reader what pg_attribute_printf is for.
2015-03-26 14:03:25 -04:00
..
.gitignore Update .gitignore for pg_upgrade 2014-12-17 11:55:22 +01:00
check.c pg_upgrade: quote directory names in delete_old_cluster script 2015-02-11 22:06:04 -05:00
controldata.c pg_upgrade: improve checksum mismatch error message 2015-02-11 22:22:26 -05:00
dump.c Update copyright for 2015 2015-01-06 11:43:47 -05:00
exec.c Update copyright for 2015 2015-01-06 11:43:47 -05:00
file.c Update copyright for 2015 2015-01-06 11:43:47 -05:00
function.c Update copyright for 2015 2015-01-06 11:43:47 -05:00
IMPLEMENTATION
info.c Update copyright for 2015 2015-01-06 11:43:47 -05:00
Makefile pg_upgrade: remove support for 8.3 old clusters 2014-08-25 20:05:07 -04:00
option.c Update copyright for 2015 2015-01-06 11:43:47 -05:00
page.c Update copyright for 2015 2015-01-06 11:43:47 -05:00
parallel.c Update copyright for 2015 2015-01-06 11:43:47 -05:00
pg_upgrade.c Update copyright for 2015 2015-01-06 11:43:47 -05:00
pg_upgrade.h Tweak __attribute__-wrapping macros for better pgindent results. 2015-03-26 14:03:25 -04:00
relfilenode.c pg_upgrade: fix one-byte per empty db memory leak 2015-01-09 12:12:30 -05:00
server.c Update copyright for 2015 2015-01-06 11:43:47 -05:00
tablespace.c Update copyright for 2015 2015-01-06 11:43:47 -05:00
test.sh Update copyright for 2015 2015-01-06 11:43:47 -05:00
TESTING Rename 'gmake' to 'make' in docs and recommended commands 2014-02-12 17:29:19 -05:00
util.c Tweak __attribute__-wrapping macros for better pgindent results. 2015-03-26 14:03:25 -04:00
version.c Update copyright for 2015 2015-01-06 11:43:47 -05:00