postgresql/contrib/pageinspect
Michael Paquier d61a361d1a Remove all traces of tuplestore_donestoring() in the C code
This routine is a no-op since dd04e95 from 2003, with a macro kept
around for compatibility purposes.  This has led to the same code
patterns being copy-pasted around for no effect, sometimes in confusing
ways like in pg_logical_slot_get_changes_guts() from logical.c where the
code was actually incorrect.

This issue has been discussed on two different threads recently, so
rather than living with this legacy, remove any uses of this routine in
the C code to simplify things.  The compatibility macro is kept to avoid
breaking any out-of-core modules that depend on it.

Reported-by: Tatsuhito Kasahara, Justin Pryzby
Author: Tatsuhito Kasahara
Discussion: https://postgr.es/m/20211217200419.GQ17618@telsasoft.com
Discussion: https://postgr.es/m/CAP0=ZVJeeYfAeRfmzqAF2Lumdiv4S4FewyBnZd4DPTrsSQKJKw@mail.gmail.com
2022-02-17 09:52:02 +09:00
..
expected Reduce non-leaf keys overlap in GiST indexes produced by a sorted build 2022-02-07 23:20:42 +03:00
sql pageinspect: Improve page_header() for pages of 32kB 2021-07-12 11:05:27 +09:00
.gitignore
brinfuncs.c Remove all traces of tuplestore_donestoring() in the C code 2022-02-17 09:52:02 +09:00
btreefuncs.c pageinspect: Make page deletion elog less chatty. 2021-09-17 14:19:51 -07:00
fsmfuncs.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
ginfuncs.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
gistfuncs.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
hashfuncs.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
heapfuncs.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
Makefile pageinspect: Improve page_header() for pages of 32kB 2021-07-12 11:05:27 +09:00
pageinspect--1.0--1.1.sql
pageinspect--1.1--1.2.sql
pageinspect--1.2--1.3.sql
pageinspect--1.3--1.4.sql
pageinspect--1.4--1.5.sql
pageinspect--1.5--1.6.sql
pageinspect--1.5.sql
pageinspect--1.6--1.7.sql
pageinspect--1.7--1.8.sql pageinspect: Fix types used for bt_metap() columns. 2020-03-07 16:44:53 -08:00
pageinspect--1.8--1.9.sql Use full 64-bit XIDs in deleted nbtree pages. 2021-02-24 18:41:34 -08:00
pageinspect--1.9--1.10.sql pageinspect: Improve page_header() for pages of 32kB 2021-07-12 11:05:27 +09:00
pageinspect.control pageinspect: Improve page_header() for pages of 32kB 2021-07-12 11:05:27 +09:00
pageinspect.h Update copyright for 2022 2022-01-07 19:04:57 -05:00
rawpage.c Update copyright for 2022 2022-01-07 19:04:57 -05:00