mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-10-06 13:56:56 +02:00
e70abd67c3
This makes use of StringInfo to assemble command lines, instead of
using fixed-size buffers and the (remote) possibility of "command too
long" errors. Also makes the code a bit simpler.
This covers the test driver programs pg_regress and
pg_isolation_regress.
Similar to the changes done for pg_rewind in a33e17f210.
Discussion: https://www.postgresql.org/message-id/2be4fee5-738f-4749-b9f8-b452032c7ade%40eisentraut.org
144 lines
3.9 KiB
C
144 lines
3.9 KiB
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* isolation_main --- pg_regress test launcher for isolation tests
|
|
*
|
|
* Portions Copyright (c) 1996-2024, PostgreSQL Global Development Group
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
*
|
|
* src/test/isolation/isolation_main.c
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
|
|
#include "postgres_fe.h"
|
|
|
|
#include "lib/stringinfo.h"
|
|
#include "pg_regress.h"
|
|
|
|
char saved_argv0[MAXPGPATH];
|
|
char isolation_exec[MAXPGPATH];
|
|
bool looked_up_isolation_exec = false;
|
|
|
|
#define PG_ISOLATION_VERSIONSTR "isolationtester (PostgreSQL) " PG_VERSION "\n"
|
|
|
|
/*
|
|
* start an isolation tester process for specified file (including
|
|
* redirection), and return process ID
|
|
*/
|
|
static PID_TYPE
|
|
isolation_start_test(const char *testname,
|
|
_stringlist **resultfiles,
|
|
_stringlist **expectfiles,
|
|
_stringlist **tags)
|
|
{
|
|
PID_TYPE pid;
|
|
char infile[MAXPGPATH];
|
|
char outfile[MAXPGPATH];
|
|
char expectfile[MAXPGPATH];
|
|
StringInfoData psql_cmd;
|
|
char *appnameenv;
|
|
|
|
/* need to do the path lookup here, check isolation_init() for details */
|
|
if (!looked_up_isolation_exec)
|
|
{
|
|
/* look for isolationtester binary */
|
|
if (find_other_exec(saved_argv0, "isolationtester",
|
|
PG_ISOLATION_VERSIONSTR, isolation_exec) != 0)
|
|
{
|
|
fprintf(stderr, _("could not find proper isolationtester binary\n"));
|
|
exit(2);
|
|
}
|
|
looked_up_isolation_exec = true;
|
|
}
|
|
|
|
/*
|
|
* Look for files in the output dir first, consistent with a vpath search.
|
|
* This is mainly to create more reasonable error messages if the file is
|
|
* not found. It also allows local test overrides when running pg_regress
|
|
* outside of the source tree.
|
|
*/
|
|
snprintf(infile, sizeof(infile), "%s/specs/%s.spec",
|
|
outputdir, testname);
|
|
if (!file_exists(infile))
|
|
snprintf(infile, sizeof(infile), "%s/specs/%s.spec",
|
|
inputdir, testname);
|
|
|
|
snprintf(outfile, sizeof(outfile), "%s/results/%s.out",
|
|
outputdir, testname);
|
|
|
|
snprintf(expectfile, sizeof(expectfile), "%s/expected/%s.out",
|
|
outputdir, testname);
|
|
if (!file_exists(expectfile))
|
|
snprintf(expectfile, sizeof(expectfile), "%s/expected/%s.out",
|
|
inputdir, testname);
|
|
|
|
add_stringlist_item(resultfiles, outfile);
|
|
add_stringlist_item(expectfiles, expectfile);
|
|
|
|
initStringInfo(&psql_cmd);
|
|
|
|
if (launcher)
|
|
appendStringInfo(&psql_cmd, "%s ", launcher);
|
|
|
|
appendStringInfo(&psql_cmd,
|
|
"\"%s\" \"dbname=%s\" < \"%s\" > \"%s\" 2>&1",
|
|
isolation_exec,
|
|
dblist->str,
|
|
infile,
|
|
outfile);
|
|
|
|
appnameenv = psprintf("isolation/%s", testname);
|
|
setenv("PGAPPNAME", appnameenv, 1);
|
|
free(appnameenv);
|
|
|
|
pid = spawn_process(psql_cmd.data);
|
|
|
|
if (pid == INVALID_PID)
|
|
{
|
|
fprintf(stderr, _("could not start process for test %s\n"),
|
|
testname);
|
|
exit(2);
|
|
}
|
|
|
|
unsetenv("PGAPPNAME");
|
|
|
|
pfree(psql_cmd.data);
|
|
|
|
return pid;
|
|
}
|
|
|
|
static void
|
|
isolation_init(int argc, char **argv)
|
|
{
|
|
size_t argv0_len;
|
|
|
|
/*
|
|
* We unfortunately cannot do the find_other_exec() lookup to find the
|
|
* "isolationtester" binary here. regression_main() calls the
|
|
* initialization functions before parsing the commandline arguments and
|
|
* thus hasn't changed the library search path at this point which in turn
|
|
* can cause the "isolationtester -V" invocation that find_other_exec()
|
|
* does to fail since it's linked to libpq. So we instead copy argv[0]
|
|
* and do the lookup the first time through isolation_start_test().
|
|
*/
|
|
argv0_len = strlcpy(saved_argv0, argv[0], MAXPGPATH);
|
|
if (argv0_len >= MAXPGPATH)
|
|
{
|
|
fprintf(stderr, _("path for isolationtester executable is longer than %d bytes\n"),
|
|
(int) (MAXPGPATH - 1));
|
|
exit(2);
|
|
}
|
|
|
|
/* set default regression database name */
|
|
add_stringlist_item(&dblist, "isolation_regression");
|
|
}
|
|
|
|
int
|
|
main(int argc, char *argv[])
|
|
{
|
|
return regression_main(argc, argv,
|
|
isolation_init,
|
|
isolation_start_test,
|
|
NULL /* no postfunc needed */ );
|
|
}
|