Tom Lane 7a844c77ec Fix joinclause removal logic to cope with cloned clauses. ... When we're deleting a no-op LEFT JOIN from the query, we must remove the join's joinclauses from surviving relations' joininfo lists. The invention of "cloned" clauses in 2489d76c4 broke the logic for that; it'd fail to remove clones that include OJ relids outside the doomed join's min relid sets, which could happen if that join was previously discovered to commute with some other join. This accidentally failed to cause problems in the majority of cases, because we'd never decide that such a cloned clause was evaluatable at any surviving join. However, Richard Guo discovered a case where that did happen, leading to "no relation entry for relid" errors later. Also, adding assertions that a non-removed clause contains no Vars from the doomed join exposes that there are quite a few existing regression test cases where the problem happens but is accidentally not exposed. The fix for this is just to include the target join's commute_above_r and commute_below_l sets in the relid set we test against when deciding whether a join clause is "pushed down" and thus not removable. While at it, do a little refactoring: the join's relid set can be computed inside remove_rel_from_query rather than in the caller. Patch by me; thanks to Richard Guo for review. Discussion: https://postgr.es/m/CAMbWs4_PHrRqTKDNnTRsxxQy6BtYCVKsgXm1_gdN2yQ=kmcO5g@mail.gmail.com		2023-05-26 12:13:19 -04:00
..
backend	Fix joinclause removal logic to cope with cloned clauses.	2023-05-26 12:13:19 -04:00
bin	Fix pgbench in prepared mode with an empty pipeline	2023-05-25 12:36:18 +02:00
common	Pre-beta mechanical code beautification.	2023-05-19 17:24:48 -04:00
fe_utils	Pre-beta mechanical code beautification.	2023-05-19 17:24:48 -04:00
include	Fix filtering of "cloned" outer-join quals some more.	2023-05-25 10:28:33 -04:00
interfaces	Spell the values of libpq's gssdelegation parameter as "0" and "1".	2023-05-22 11:50:27 -04:00
makefiles	Use --strip-unneeded when stripping static libraries with GNU strip.	2023-04-20 18:12:32 -04:00
pl	Translation updates	2023-05-22 12:44:31 +02:00
port	Pre-beta mechanical code beautification.	2023-05-19 17:24:48 -04:00
template	Use unnamed POSIX semaphores on Cygwin.	2023-01-06 10:33:28 +13:00
test	Fix joinclause removal logic to cope with cloned clauses.	2023-05-26 12:13:19 -04:00
timezone	Pre-beta mechanical code beautification.	2023-05-19 17:24:48 -04:00
tools	Doc: update src/tools/pginclude/README.	2023-05-23 18:51:43 -04:00
tutorial	Pre-beta mechanical code beautification.	2023-05-19 17:24:48 -04:00
.gitignore
DEVELOPERS
Makefile	Integrate pg_bsd_indent into our build/test infrastructure.	2023-02-12 12:22:21 -05:00
Makefile.global.in	Fix prove_installcheck when used with PGXS	2023-05-05 07:09:52 +02:00
Makefile.shlib	autoconf: Rely on ar supporting index creation	2022-10-07 11:53:39 -07:00
meson.build	Integrate pg_bsd_indent into our build/test infrastructure.	2023-02-12 12:22:21 -05:00
nls-global.mk	Fix for make unportability	2022-07-13 09:15:01 +02:00