mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-09-04 14:37:22 +02:00
Whenever this function is used with the FORMAT_MESSAGE_FROM_SYSTEM flag, it's good practice to include FORMAT_MESSAGE_IGNORE_INSERTS as well. Otherwise, if the message contains any %n insertion markers, the function will try to fetch argument strings to substitute --- which we are not passing, possibly leading to a crash. This is exactly analogous to the rule about not giving printf() a format string you're not in control of. Noted and patched by Christian Ullrich. Back-patch to all supported branches. |
||
---|---|---|
.. | ||
.gitignore | ||
chklocale.c | ||
crypt.c | ||
dirent.c | ||
dirmod.c | ||
erand48.c | ||
fls.c | ||
fseeko.c | ||
getaddrinfo.c | ||
getopt_long.c | ||
getopt.c | ||
getpeereid.c | ||
getrusage.c | ||
gettimeofday.c | ||
inet_aton.c | ||
inet_net_ntop.c | ||
isinf.c | ||
kill.c | ||
Makefile | ||
mkdtemp.c | ||
noblock.c | ||
open.c | ||
path.c | ||
pg_crc32c_choose.c | ||
pg_crc32c_sb8.c | ||
pg_crc32c_sse42.c | ||
pgcheckdir.c | ||
pgmkdirp.c | ||
pgsleep.c | ||
pgstrcasecmp.c | ||
pqsignal.c | ||
pthread-win32.h | ||
qsort_arg.c | ||
qsort.c | ||
quotes.c | ||
random.c | ||
README | ||
rint.c | ||
snprintf.c | ||
sprompt.c | ||
srandom.c | ||
strerror.c | ||
strlcat.c | ||
strlcpy.c | ||
system.c | ||
tar.c | ||
thread.c | ||
unsetenv.c | ||
win32.ico | ||
win32env.c | ||
win32error.c | ||
win32security.c | ||
win32setlocale.c | ||
win32ver.rc |
src/port/README libpgport ========= libpgport must have special behavior. It supplies functions to both libraries and applications. However, there are two complexities: 1) Libraries need to use object files that are compiled with exactly the same flags as the library. libpgport might not use the same flags, so it is necessary to recompile the object files for individual libraries. This is done by removing -lpgport from the link line: # Need to recompile any libpgport object files LIBS := $(filter-out -lpgport, $(LIBS)) and adding infrastructure to recompile the object files: OBJS= execute.o typename.o descriptor.o data.o error.o prepare.o memory.o \ connect.o misc.o path.o exec.o \ $(filter snprintf.o, $(LIBOBJS)) The problem is that there is no testing of which object files need to be added, but missing functions usually show up when linking user applications. 2) For applications, we use -lpgport before -lpq, so the static files from libpgport are linked first. This avoids having applications dependent on symbols that are _used_ by libpq, but not intended to be exported by libpq. libpq's libpgport usage changes over time, so such a dependency is a problem. Win32, Linux, and Darwin use an export list to control the symbols exported by libpq.