rdelaage
/
postgresql
mirror of https://git.postgresql.org/git/postgresql.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
postgresql/contrib/pageinspect
History
Tom Lane b66827ca7c Fix tuple_data_split() to not open a relation without any lock. 
contrib/pageinspect's tuple_data_split() function thought it could get
away with opening the referenced relation with NoLock.  In practice
there's no guarantee that the current session holds any lock on that
rel (even if we just read a page from it), so that this is unsafe.

Switch to using AccessShareLock.  Also, postpone closing the relation,
so that we needn't copy its tupdesc.  Also, fix unsafe use of
att_isnull() for attributes past the end of the tuple.

Per testing with a patch that complains if we open a relation without
holding any lock on it.  I don't plan to back-patch that patch, but we
should close the holes it identifies in all supported branches.

Discussion: https://postgr.es/m/2038.1538335244@sss.pgh.pa.us
 		2018-10-01 11:51:07 -04:00
..
expected pgstatindex, pageinspect: handle partitioned indexes 2018-05-09 14:22:59 -03:00
sql pgstatindex, pageinspect: handle partitioned indexes 2018-05-09 14:22:59 -03:00
.gitignore pageinspect: Add tests 2016-11-01 14:02:16 -04:00
Makefile Skip full index scan during cleanup of B-tree indexes when possible 2018-04-04 19:29:00 +03:00
brinfuncs.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
btreefuncs.c Make error message of pageinspect more consistent for raw page inputs 2018-07-29 23:50:35 +09:00
fsmfuncs.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
ginfuncs.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
hashfuncs.c Clean up warnings from -Wimplicit-fallthrough. 2018-05-01 19:35:08 -04:00
heapfuncs.c Fix tuple_data_split() to not open a relation without any lock. 2018-10-01 11:51:07 -04:00
pageinspect--1.0--1.1.sql Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:37 +02:00
pageinspect--1.1--1.2.sql Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:37 +02:00
pageinspect--1.2--1.3.sql pageinspect/BRIN: minor tweaks 2014-12-02 12:20:50 -03:00
pageinspect--1.3--1.4.sql Add forgotten file in commit d6061f83a1 2015-11-25 16:59:07 +03:00
pageinspect--1.4--1.5.sql Update pageinspect extension for parallel query. 2016-06-09 17:18:09 -04:00
pageinspect--1.5--1.6.sql pageinspect: Add bt_page_items function with bytea argument 2017-04-04 23:52:55 -04:00
pageinspect--1.5.sql Update pageinspect extension for parallel query. 2016-06-09 17:18:09 -04:00
pageinspect--1.6--1.7.sql Skip full index scan during cleanup of B-tree indexes when possible 2018-04-04 19:29:00 +03:00
pageinspect--unpackaged--1.0.sql Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:37 +02:00
pageinspect.control Skip full index scan during cleanup of B-tree indexes when possible 2018-04-04 19:29:00 +03:00
pageinspect.h Update copyright for 2018 2018-01-02 23:30:12 -05:00
rawpage.c Make error message of pageinspect more consistent for raw page inputs 2018-07-29 23:50:35 +09:00