postgresql

mirror of https://git.postgresql.org/git/postgresql.git synced 2024-08-25 06:47:19 +02:00

History

Tom Lane 7b67a0a49c Fix some interrelated planner issues with initPlans and Param munging. In commit `68fa28f77` I tried to teach SS_finalize_plan() to cope with initPlans attached anywhere in the plan tree, by dint of moving its handling of those into the recursion in finalize_plan(). It turns out that that doesn't really work: if a lower-level plan node emits an initPlan output parameter in its targetlist, it's legitimate for upper levels to reference those Params --- and at the point where this code runs, those references look just like the Param itself, so finalize_plan() quite properly rejects them as being in the wrong place. We could lobotomize the checks enough to allow that, probably, but then it's not clear that we'd have any meaningful check for misplaced Params at all. What seems better, at least in the near term, is to tweak standard_planner() a bit so that initPlans are never placed anywhere but the topmost plan node for a query level, restoring the behavior that occurred pre-9.6. Possibly we can do better if this code is ever merged into setrefs.c: then it would be possible to check a Param's placement only when we'd failed to replace it with a Var referencing a child plan node's targetlist. BTW, I'm now suspicious that finalize_plan is doing the wrong thing by returning the node's allParam rather than extParam to be incorporated in the parent node's set of used parameters. However, it makes no difference given that initPlans only appear at top level, so I'll leave that alone for now. Another thing that emerged from this is that standard_planner() needs to check for initPlans before deciding that it's safe to stick a Gather node on top in force_parallel_mode mode. We previously guarded against that by deciding the plan wasn't wholePlanParallelSafe if any subplans had been found, but after commit `5ce5e4a12` it's necessary to have this substitute test, because path parallel_safe markings don't account for initPlans. (Normally, we'd have decided the paths weren't safe anyway due to appearances of SubPlan nodes, Params, or CTE scans somewhere in the tree --- but it's possible for those all to be optimized away while initPlans still remain.) Per fuzz testing by Andreas Seltenreich. Report: <874m89rw7x.fsf@credativ.de>		2016-07-01 20:06:05 -04:00
..
examples	Update copyright for 2016	2016-01-02 13:33:40 -05:00
isolation	Use memmove() not memcpy() to slide some pointers down.	2016-04-27 18:19:28 -04:00
locale	Fix omission of -X (--no-psqlrc) in some psql invocations.	2015-12-28 11:46:43 -05:00
mb	Revert "Fix broken multibyte regression tests."	2016-01-26 08:29:15 +09:00
modules	Provide and use a makefile target to build all generated headers.	2016-07-01 15:09:02 -04:00
perl	Finish pgindent run for 9.6: Perl files.	2016-06-12 04:19:56 -04:00
recovery	Finish pgindent run for 9.6: Perl files.	2016-06-12 04:19:56 -04:00
regress	Fix some interrelated planner issues with initPlans and Param munging.	2016-07-01 20:06:05 -04:00
ssl	Clean the last few TAP suite tmp_check directories.	2016-02-24 23:41:54 -05:00
thread	Update copyright for 2016	2016-01-02 13:33:40 -05:00
Makefile	Add a test framework for recovery	2016-02-26 16:13:30 -03:00
README	Minor tweaks for new src/test/recovery	2016-02-29 18:16:59 -03:00

README

PostgreSQL tests
================

This directory contains a variety of test infrastructure as well as some of the
tests in PostgreSQL. Not all tests are here -- in particular, there are more in
individual contrib/ modules and in src/bin.

Not all these tests get run by "make check". Check src/test/Makefile to see
which tests get run automatically.

examples/
  Demonstration programs for libpq that double as regression tests via
  "make check"

isolation/
  Tests for concurrent behavior at the SQL level

locale/
  Sanity checks for locale data, encodings, etc

mb/
  Tests for multibyte encoding (UTF-8) support

modules/
  Extensions used only or mainly for test purposes, generally not suitable
  for installing in production databases

perl/
  Infrastructure for Perl-based TAP tests

recovery/
  Test suite for recovery and replication

regress/
  PostgreSQL's main regression test suite, pg_regress

ssl/
  Tests to exercise and verify SSL certificate handling

thread/
  A thread-safety-testing utility used by configure