Tom Lane 7ea20a2bc6 Avoid failure if autovacuum tries to access a just-dropped temp namespace. ... Such an access became possible when commit 246a6c8f7 added more aggressive cleanup of orphaned temp relations by autovacuum. Since autovacuum's snapshot might be slightly stale, it could attempt to access an already-dropped temp namespace, resulting in an assertion failure or null-pointer dereference. (In practice, since we don't drop temp namespaces automatically but merely recycle them, this situation could only arise if a superuser does a manual drop of a temp namespace. Still, that should be allowed.) The core of the bug, IMO, is that isTempNamespaceInUse and its callers failed to think hard about whether to treat "temp namespace isn't there" differently from "temp namespace isn't in use". In hopes of forestalling future mistakes of the same ilk, replace that function with a new one checkTempNamespaceStatus, which makes the same tests but returns a three-way enum rather than just a bool. isTempNamespaceInUse is gone entirely in HEAD; but just in case some external code is relying on it, keep it in the back branches, as a bug-compatible wrapper around the new function. Per report originally from Prabhat Kumar Sahu, investigated by Mahendra Singh and Michael Paquier; the final form of the patch is my fault. This replaces the failed fix attempt in a052f6cbb. Backpatch as far as v11, as 246a6c8f7 was. Discussion: https://postgr.es/m/CAKYtNAr9Zq=1-ww4etHo-VCC-k120YxZy5OS01VkaLPaDbv2tg@mail.gmail.com		2020-02-28 20:28:34 -05:00
..
backend	Avoid failure if autovacuum tries to access a just-dropped temp namespace.	2020-02-28 20:28:34 -05:00
bin	Remove TAP test for createdb --lc-ctype	2020-02-27 21:58:50 +09:00
common	Fix typo	2020-02-19 21:09:39 +01:00
fe_utils	Fix translation of special characters in psql's LaTeX output modes.	2018-11-26 17:32:51 -05:00
include	Avoid failure if autovacuum tries to access a just-dropped temp namespace.	2020-02-28 20:28:34 -05:00
interfaces	Stamp 11.7.	2020-02-10 17:17:28 -05:00
makefiles	Select CFLAGS_SL at configure time, not in platform-specific Makefiles.	2019-10-21 12:32:36 -04:00
pl	Fix confusion about event trigger vs. plain function in plpgsql.	2020-02-19 14:44:58 -05:00
port	Stamp 11.7.	2020-02-10 17:17:28 -05:00
template	Select CFLAGS_SL at configure time, not in platform-specific Makefiles.	2019-10-21 12:32:36 -04:00
test	Fix confusion about event trigger vs. plain function in plpgsql.	2020-02-19 14:44:58 -05:00
timezone	Update time zone data files to tzdata release 2019c.	2019-09-20 19:54:00 -04:00
tools	Handle spaces in OpenSSL install location for MSVC	2019-10-04 15:39:19 -04:00
tutorial	Update copyright for 2018	2018-01-02 23:30:12 -05:00
.gitignore
DEVELOPERS
Makefile	Fix partial-build problems introduced by having more generated headers.	2018-04-09 16:42:10 -04:00
Makefile.global.in	Select CFLAGS_SL at configure time, not in platform-specific Makefiles.	2019-10-21 12:32:36 -04:00
Makefile.shlib	Ensure static libraries have correct mod time even if ranlib messes it up.	2018-11-29 15:53:44 -05:00
nls-global.mk