Robert Haas 80d5e3a615 amcheck: Tighten up validation of redirect line pointers. ... Commit bbc1376b39 added a new lp_valid[] array which records whether or not a line pointer was thought to be valid, but entries could sometimes get set to true in cases where that wasn't actually safe. Fix that. Suppose A is a redirect line pointer and B is the other line pointer to which it points. The old code could mishandle this situation in a couple of different ways. First, if B was unused, we'd complain about corruption but still set lp_valid[A] = true, causing later code to try to access the B as if it were pointing to a tuple. Second, if B was dead, we wouldn't complain about corruption at all, which is an oversight, and would also set lp_valid[A] = true, which would again confuse later code. Fix all that. In the case where B is a redirect, the old code was correct, but refactor things a bit anyway so that all of these cases are handled more symmetrically. Also add an Assert() and some comments. Andres Freund and Robert Haas Discussion: http://postgr.es/m/20230323172607.y3lejpntjnuis5vv%40awork3.anarazel.de		2023-03-27 13:36:11 -04:00
..
expected	Add tests for pg_stat_io	2023-02-11 10:05:04 -08:00
sql	Add tests for pg_stat_io	2023-02-11 10:05:04 -08:00
t	Update copyright for 2023	2023-01-02 15:00:37 -05:00
.gitignore	Add .gitignore to contrib/amcheck.	2017-03-09 22:45:24 -05:00
amcheck--1.0--1.1.sql	Add amcheck verification of heap relations belonging to btree indexes.	2018-03-31 19:52:01 -07:00
amcheck--1.0.sql	Add amcheck extension to contrib.	2017-03-09 16:33:02 -08:00
amcheck--1.1--1.2.sql	Allow amcheck to re-find tuples using new search.	2019-03-20 10:41:36 -07:00
amcheck--1.2--1.3.sql	Extend amcheck to check heap pages.	2020-10-22 08:44:18 -04:00
amcheck.control	Extend amcheck to check heap pages.	2020-10-22 08:44:18 -04:00
Makefile	Extend amcheck to check heap pages.	2020-10-22 08:44:18 -04:00
meson.build	Update copyright for 2023	2023-01-02 15:00:37 -05:00
verify_heapam.c	amcheck: Tighten up validation of redirect line pointers.	2023-03-27 13:36:11 -04:00
verify_nbtree.c	Update copyright for 2023	2023-01-02 15:00:37 -05:00