postgresql/src/backend/lib
David Rowley 4b31063643 Fix broken Bitmapset optimization in DiscreteKnapsack()
Some code in DiscreteKnapsack() attempted to zero all words in a
Bitmapset by performing bms_del_members() to delete all the members from
itself before replacing those members with members from another set.
When that code was written, this was a valid way to manipulate the set
in such a way to save from palloc having to be called to allocate a new
Bitmapset.  However, 00b41463c modified Bitmapsets so that an empty set is
*always* represented as NULL and this breaks the optimization as the
Bitmapset code will always pfree the memory when the set becomes empty.

Since DiscreteKnapsack() has been coded to avoid as many unneeded
allocations as possible, it seems risky to not fix this.  Here we add
bms_replace_members() to effectively perform an in-place copy of another
set, reusing the memory of the existing set, when possible.

This got broken in v16, but no backpatch for now as there've been no
complaints.

Reviewed-by: Richard Guo
Discussion: https://postgr.es/m/CAApHDvoTCBkBU2PJghNOFUiO0q=QP4WAWHi5sJP6_4=b2WodrA@mail.gmail.com
2024-01-19 10:44:36 +13:00
..
Makefile Make binaryheap available to frontend code. 2023-09-18 12:18:33 -07:00
README Add IntegerSet, to hold large sets of 64-bit ints efficiently. 2019-03-22 13:21:45 +02:00
bipartite_match.c Update copyright for 2024 2024-01-03 20:49:05 -05:00
bloomfilter.c Update copyright for 2024 2024-01-03 20:49:05 -05:00
dshash.c Update copyright for 2024 2024-01-03 20:49:05 -05:00
hyperloglog.c Update copyright for 2024 2024-01-03 20:49:05 -05:00
ilist.c Update copyright for 2024 2024-01-03 20:49:05 -05:00
integerset.c Update copyright for 2024 2024-01-03 20:49:05 -05:00
knapsack.c Fix broken Bitmapset optimization in DiscreteKnapsack() 2024-01-19 10:44:36 +13:00
meson.build Update copyright for 2024 2024-01-03 20:49:05 -05:00
pairingheap.c Update copyright for 2024 2024-01-03 20:49:05 -05:00
rbtree.c Update copyright for 2024 2024-01-03 20:49:05 -05:00

README

This directory contains a general purpose data structures, for use anywhere
in the backend:

binaryheap.c - a binary heap

bipartite_match.c - Hopcroft-Karp maximum cardinality algorithm for bipartite graphs

bloomfilter.c - probabilistic, space-efficient set membership testing

dshash.c - concurrent hash tables backed by dynamic shared memory areas

hyperloglog.c - a streaming cardinality estimator

ilist.c - single and double-linked lists

integerset.c - a data structure for holding large set of integers

knapsack.c - knapsack problem solver

pairingheap.c - a pairing heap

rbtree.c - a red-black tree

stringinfo.c - an extensible string type


Aside from the inherent characteristics of the data structures, there are a
few practical differences between the binary heap and the pairing heap. The
binary heap is fully allocated at creation, and cannot be expanded beyond the
allocated size. The pairing heap on the other hand has no inherent maximum
size, but the caller needs to allocate each element being stored in the heap,
while the binary heap works with plain Datums or pointers.

The linked-lists in ilist.c can be embedded directly into other structs, as
opposed to the List interface in nodes/pg_list.h.